Pickadate.js • Hacker News Board

Re: Pickadate.js

#91

Post by kevincennis » Wed, Nov 21, 2012, 2:32 AM UTC

kurrent wrote: post #40

armandososa wrote: post #17

https://github.com/amsul/pickadate.js/blob/gh-pages/pickadat... the code is a giant var statement. I don't know why, but somehow that bothers me.

looks like a single var pattern inside an immediately invoked function expression to me. works well and great for readability

Thank you for not calling it a "self-executing anonymous function".

Re: Pickadate.js

#92

Post by joshfraser » Wed, Nov 21, 2012, 2:34 AM UTC

I really like the datepicker on https://www.google.com/flights/. I wish someone would clone it for jQuery.

Re: Pickadate.js

#93

Post by lkinc » Wed, Nov 21, 2012, 2:42 AM UTC

http://jqueryui.com/datepicker/ http://chipersoft.com/Kalendae/ http://www.eyecon.ro/bootstrap-datepicker/ https://github.com/dangrossman/bootstrap-daterangepicker

Re: Pickadate.js

#94

Post by thezilch » Wed, Nov 21, 2012, 2:51 AM UTC

devinus wrote: post #77

tinco wrote: post #29

Earlier quoted context omitted.

The fact that the code is very neat and is well documented bothers me. Also the fact that javascript is a lot more readable when you put a blank line between every two lines bothers me (a lot!). And that it works perfectly and looks great, man that bothers me.

// If datePassed is true else if ( datePassed === true ) { Yes, very well documented. >.>

Indeed. In fact, I'd posture that the comments, after the first, are wrong; the lines' intents are to _set_!

    // Set the element as readonly
    element.readOnly = true

    // Get the date today
    DATE_TODAY = P.getDateToday()

    // Get the date to select
    DATE_SELECTED = P.getDateSelected()

    // Get the month to focus
    MONTH_FOCUSED = P.getMonthFocused()

    // Get the date ranges
    DATE_MIN = P.getDateRange( SETTINGS.date_min )
    DATE_MAX = P.getDateRange( SETTINGS.date_max, 1 )

Re: Pickadate.js

#95

Post by ilink » Wed, Nov 21, 2012, 2:53 AM UTC

electic wrote: post #31

seldo wrote: post #30

A javascript date picker? Is HN being very expertly trolled?

No. DatePickers, along with Forms, are the bane of my existence. More choices that are brought to light, the better.

Agreed! I had no idea how many bad ones there were until I needed one for a project.

Re: Pickadate.js

#96

Post by fudged71 » Wed, Nov 21, 2012, 3:05 AM UTC

joshfraser wrote: post #92

I really like the datepicker on https://www.google.com/flights/ . I wish someone would clone it for jQuery.

It seems to be far faster than the rest of the datepickers people have linked to on this page, as well. Feels great to use.

Re: Pickadate.js

#97

Post by georgeorwell » Wed, Nov 21, 2012, 3:12 AM UTC

For non-phones, what about a 4x3 grid of months?

Re: Pickadate.js

#98

Post by mwill » Wed, Nov 21, 2012, 3:25 AM UTC

vishalsankhla wrote: post #32

Wish it allowed me to type in the box..the interaction is a bit confusing..

This was actually the first thing I tried, half expecting it to smart match the text.

Re: Pickadate.js

#99

Post by stove » Wed, Nov 21, 2012, 3:46 AM UTC

Looks cool but on iOs it won't let you close the picker unless you select a date other than what's selected. Touching the input again might be a good way to close it.

Re: Pickadate.js

#100

Post by hadem » Wed, Nov 21, 2012, 3:58 AM UTC

ergo14 wrote: post #51

electic wrote: post #31

Earlier quoted context omitted.

No. DatePickers, along with Forms, are the bane of my existence. More choices that are brought to light, the better.

There you go - this will make your life easier then: http://dojotoolkit.org/reference-guide/1.8/dijit/form.html#d...

Please, never use the Dojo Toolkit. I was forced to use it on a project and working with it was reinventing the wheel while pulling out hair. It was overly complicated for something that needed to be straightforward and simple.