Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Issue links now open in a popup

github.com

Post reply on HN
Print view View original

71–80 of 138 posts

Re: Issue links now open in a popup

#71

Post by crazygringo »

I'm completely confused by the issue, the linked page is a terribly unclear description. It doesn't clearly explain what prior behavior was, or even what the new behavior is precisely. What on earth is this garbled English supposed to mean:

> any link to an issue form an issue stared to open in a popup overlay instead of navigating to it

When I use GitHub now, I see that when I hover over a link to an issue, it provides a hover popup after a fraction of a second. I can still click the original link to navigate to the issue, or move my mouse and the popup goes away.

Is the complaint that these hover popups exist at all? Or is something else happening to certain people that they're complaining about? There isn't a link to an example page or anything. I'm just baffled here.

Re: Issue links now open in a popup

#72

Post by ezfe »

Neywiny wrote: post #68
Matt138 wrote: post #66

This was a performance driven change. We added this as loading a cross repo issue is a much slower experience than loading an issue in the same repo due to the way the header is loaded (which is being worked on). But we hear you on the feedback - we will roll this back while we keep pushing on the root performance causes. [update - this change has been reverted and the previous behaviour is back]

Can you elaborate? The header meaning the top part of the page? I just checked on a recent repo I visited and it has the usual banner (which would stay the same), the repo path, some links, and some stats. Considering every page navigation would likely pull which links and stats are shown, why is this a delta to go to another repo and why are presumably 3 database entries (possible links, stars, forks) so slow?

Navigation within a repository does not reload the page, only the section below the header.

Re: Issue links now open in a popup

#73

Post by Xunjin »

Matt138 wrote: post #66

This was a performance driven change. We added this as loading a cross repo issue is a much slower experience than loading an issue in the same repo due to the way the header is loaded (which is being worked on). But we hear you on the feedback - we will roll this back while we keep pushing on the root performance causes. [update - this change has been reverted and the previous behaviour is back]

To be honest GitHub should have like a switch for "preview stuff adopter" where you guys could give any benefits for it (maybe more copilot usage?). This way you can test with a specific public, using metrics and feedback, while testing and people could comment more about it.

Re: Issue links now open in a popup

#74

Post by input_sh »

willio58 wrote: post #7

It’s always been interesting to me that multi-million and even billion dollar tech companies don’t have perfect websites in terms of UX. Just last night I was helping my GF set up an ad for her job on LinkedIn. The UX was terrible. Like awful and basic things like save and exit were completely broken. Meanwhile LinkedIn makes what percentage of their revenue through ads? Same with google ads. It’s like these products…

It gets increasingly difficult to design a website properly when you have different teams with different goals each competing to put their little feature front-and-centre, leading to a hacky job on top of a hacky job on top of a hacky job, which in turn hurts the performance until one day someone finally decides to re-think the whole thing from scratch and pisses off >50% of its users in the process that are used to the mess.

It's way easier to nail the UX when you're still in the dozens-of-employees stage of growth and offer like five features in total.

Re: Issue links now open in a popup

#75

Post by gardnr »

They keep adding “fancy” UI and hijacking standard browser behaviour that is infuriating on a daily basis.

Please consider a lofi version for people that want to select text without navigating to a different page.

Re: Issue links now open in a popup

#76

Post by akersten »

GitHub issues (well, PR comments specifically) is possibly the clearest example of developers not knowing how their users use the product. There are only 3 important user stories that matter for this workflow and none of them are done well:

- I want to review surrounding code and get context for a line level change. Can't do it without clicking multiple expanders and even that has a limit of 2 or 3. I also can't comment on surrounding unchanged code which is sometimes extremely relevant, like "copy this pattern"

- I want to see all the unaddressed issues. Ones that are not marked as resolved and not replied to, however you slice it, the issue filters simply don't work

- I don't want the PR author to be able to resolve issues without me getting indicated to verify them. The workaround is them commenting "fixed" on every issue. Make the button say "mark as resolved" and "verify resolved"

- Bonus: if you've got more than 40 comments on a PR, good luck finding some random subset of them. They're just unavailable and the UI unapologetically says "eh can't do it". Yeah small PRs but it happens.

Popup or inline i don't really care, the baseline workflow is completely uninformed.

Re: Issue links now open in a popup

#78

Post by mvdtnz »

Neywiny wrote: post #68
Matt138 wrote: post #66

This was a performance driven change. We added this as loading a cross repo issue is a much slower experience than loading an issue in the same repo due to the way the header is loaded (which is being worked on). But we hear you on the feedback - we will roll this back while we keep pushing on the root performance causes. [update - this change has been reverted and the previous behaviour is back]

Can you elaborate? The header meaning the top part of the page? I just checked on a recent repo I visited and it has the usual banner (which would stay the same), the repo path, some links, and some stats. Considering every page navigation would likely pull which links and stats are shown, why is this a delta to go to another repo and why are presumably 3 database entries (possible links, stars, forks) so slow?

I can't speak for GitHub but I've worked on multiple nav headers for large SaaS products and they can be ridiculously heavy weight to render given they appear on every page. They tend to be a dumping ground for features, many of which require their own permissions checks, feature flag checks, etc. it's not unusual to have to perform hierarchical permissions checks. They also tend to contain contextual info about the current nav state and dynamic information about navigable states.

A lot of this can be cached but it's easy to see why moving from one repo to another will invalidate most or all permission checks and feature flag checks.

Re: Issue links now open in a popup

#79

Post by eMPee584 »

piptastic wrote: post #61
crtasm wrote: post #42

Earlier quoted context omitted.

Split tabs are now in: https://support.mozilla.org/en-US/kb/split-view-firefox

Chrome also has split tabs since Feb '26 right click a link, open in split view

KDE's hybrid file / web browser konqueror has had arbitrary tab tiling since 1999 IIRC.. still a gread tool, would just need some love and webextensions support to come back big

Re: Issue links now open in a popup

#80

Post by rafram »

vbezhenar wrote: post #69
piptastic wrote: post #61

Earlier quoted context omitted.

Chrome also has split tabs since Feb '26 right click a link, open in split view

I hate that feature and I hate that they keep bloating browser which was lightweight. Just for the record.

When was Chrome lightweight? 15 years ago?
Post reply on HN