31–40 of 45 posts
If this is failing for you, make sure you haven't blocked twitter using Ghostery or the like, as this causes the script to error out. Uncaught ReferenceError: twttr is not defined app.js:196 setupWinner app.js:196 Maybe the script can be made a bit more robust in this case?
Earlier quoted context omitted.
are there still repos left under the processing box? if so, would you mind checking your console?
Uncaught ReferenceError: twttr is not defined EDIT: My cookie-blocking plugin apparently was blocking something critical.
If this is failing for you, make sure you haven't blocked twitter using Ghostery or the like, as this causes the script to error out. Uncaught ReferenceError: twttr is not defined app.js:196 setupWinner app.js:196 Maybe the script can be made a bit more robust in this case?
Good idea! Added a check to see if twttr is defined, if it isn't I just don't add the share through twitter button. Thanks!
I should have opened a pull request for you!
Awesome to see the quick turn around on your repo, though I haven't seen it deployed yet. It looks like you are using Heroku to deploy, have you not deployed yet or do I need to refresh my client-side resources?
Earlier quoted context omitted.
Good idea! Added a check to see if twttr is defined, if it isn't I just don't add the share through twitter button. Thanks!
No worries :) I should have opened a pull request for you! Awesome to see the quick turn around on your repo, though I haven't seen it deployed yet. It looks like you are using Heroku to deploy, have you not deployed yet or do I need to refresh my client-side resources?
Earlier quoted context omitted.
Uncaught ReferenceError: twttr is not defined EDIT: My cookie-blocking plugin apparently was blocking something critical.
Also got the same error due to the Twitter button not loading. It might be a good idea to handle that case in the code.
Earlier quoted context omitted.
No worries :) I should have opened a pull request for you! Awesome to see the quick turn around on your repo, though I haven't seen it deployed yet. It looks like you are using Heroku to deploy, have you not deployed yet or do I need to refresh my client-side resources?
Made a little mistake, sorry, should be deployed in 10 seconds.
http://www.gitbattle.com/?u1=puppetlabs&u2=opscode
(incidentally, there appears to be a UI bug where it lists some repos multiple times - at the end the list looked like puppet/chef/puppet/chef/puppet/chef )