Live data from Hacker News

WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

obr.uk

21–30 of 127 posts

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#21

For those of you not closely following UK politics: the Office for Budget Responsibility (OBR) mistakenly published their Economic and Fiscal Outlook (EFO) document 40 minutes early, pre-empting the announcements by the Chancellor. This is being treated as an incredibly big deal here: https://www.bbc.co.uk/news/articles/cd74v35p77jo

In the popular press it’s been sidelined because it would distract from the continuous attacks on the chancellor

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#22
> The available mitigation is at server level and prevents access to download or file storage directories directly. If configured properly, this will block access to the clear URL and return a ‘forbidden’ message. This is the second contributory configuration error – the server was not configured in this way so there was nothing to stop access to the clear URL bypassing protections against pre-publication access

That's the main flaw. Wordpress was configured to allow direct access to file, so they did not go through the authentication system. My experience is with Drupal (and a decade or more out of date), but it sounds like this behaves very similar. And this is a giant footgun, the system doesn't behave the way normal people expect if you allow unauthenticated access to files (if you know the URL). I don't understand why you would configure it this way today.

I would also assume that the upload happened via Wordpress, and not someone manually uploading files via FTP/SFTP or something like that. And in that case it would be entirely non-obvious to users that attaching a file to an unpublished document would put it in a place where it is potentially publicly accessible.

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#23
> It is the worst failure in the 15-year history of the OBR

I'm not sure publishing some information 3 hours early was really their biggest failure in 15 years...

Especially when much of the info was already public because hundreds of civil servants involved in making these decisions told their family members who told the press...

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#24

> It is the worst failure in the 15-year history of the OBR I'm not sure publishing some information 3 hours early was really their biggest failure in 15 years... Especially when much of the info was already public because hundreds of civil servants involved in making these decisions told their family members who told the press...

It's still a failure in principle. The effects of this particular instance of the failure were minimal but it was still an accidental leak of (at the time) private information. They just got lucky.

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#25

For those of you not closely following UK politics: the Office for Budget Responsibility (OBR) mistakenly published their Economic and Fiscal Outlook (EFO) document 40 minutes early, pre-empting the announcements by the Chancellor. This is being treated as an incredibly big deal here: https://www.bbc.co.uk/news/articles/cd74v35p77jo

In the popular press it’s been sidelined because it would distract from the continuous attacks on the chancellor

Yes, it’s getting quite ridiculous now. Labour, for sure, have not done themselves any favours in their first 18 months in charge, but the level of attack and vitriol is exceptional and beyond any reasonable level.

It makes me wonder what exactly is driving this.

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#27
post #3

Earlier quoted context omitted.

> A feature known as the Download Monitor plug-in created a webpage with the clear URL which provided a link to the live version, which bypassed the need for authentication. This rendered the protections on the ‘future’ function of WordPress redundant as it bypassed the required authentication needed to gain access to the pre-uploaded document. WordPress is a nice piece of software, but the plugin situation is gettin…

> WordPress is a nice piece of software, but the plugin situation is getting worse and worse The plugin situation is a mess largely because Wordpress isn't a nice piece of software. It's popular, and functionally it's great, but the codebase is really showing its age. Wordpress has never properly rearchitected because it would break plugins on a scale that would endanger its dominance.

> the codebase is really showing its age.

It's not age, it started very, very bad. If they'd fixed the horrible schema and the code a decade and a half ago, plugins would have been a lot easier to write (and a lot safer.)

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#28
post #24

> It is the worst failure in the 15-year history of the OBR I'm not sure publishing some information 3 hours early was really their biggest failure in 15 years... Especially when much of the info was already public because hundreds of civil servants involved in making these decisions told their family members who told the press...

It's still a failure in principle. The effects of this particular instance of the failure were minimal but it was still an accidental leak of (at the time) private information. They just got lucky.

> The effects of this particular instance of the failure were minimal

the effects are not minimal

if you're crooked: getting this sort of information early is potentially extremely lucrative

(why crooked? because trading on UPSI is illegal)

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#29

> The available mitigation is at server level and prevents access to download or file storage directories directly. If configured properly, this will block access to the clear URL and return a ‘forbidden’ message. This is the second contributory configuration error – the server was not configured in this way so there was nothing to stop access to the clear URL bypassing protections against pre-publication access That…

Since at least Drupal 7, the core CMS has included the concept of “private files.” The files are stored in a directory that is not served publicly by the web server. Instead the CMS generates a proxy URL for each file, which is handled by the CMS like a page URL before serving the file by streaming it through PHP. So: it’s a heavier load on the server, but you get full permission management by the CMS.

Wordpress does not have this in core—no surprise. I was surprised to find that it’s not even available as a community plugin. I had to pay a developer to write a custom plugin when building a members-only website in Wordpress.

Some folks downplayed the risk of someone finding and directly accessing the file URL if it wasn’t referenced on a public page. It’s crazy to see it created a national government incident in the UK.

Re: WordPress plugin quirk resulted in UK Gov OBR Budget leak [pdf]

#30
The real kicker is in point 1.13:

> website activity logs show the earliest request on the server for the URL https://obr.uk/docs/dlm_uploads/OBR_Economic_and_fiscal_outl.... This request was unsuccessful, as the document had not been uploaded yet. Between this time and 11:30, a total of 44 unsuccessful requests to this URL were made from seven unique IP addresses.

In other words, someone was guessing the correct staging URL before the OBR had even uploaded the file to the staging area. This suggests that the downloader knew that the OBR was going to make this mistake, and they were polling the server waiting for the file to appear.

The report acknowledges this at 2.11:

> In the course of reviewing last week’s events, it has become clear that the OBR publication process was essentially technically unchanged from EFOs in the recent past. This gives rise to the question as to whether the problem was a pre-existing one that had gone unnoticed.

Post reply on HN