Code review can be better • Hacker News Board

Re: Code review can be better

#21

Post by loeg » Thu, Aug 21, 2025, 2:00 AM UTC

I've used Reviewboard and Phabricator and both seem "fine" to me. Superior to Github (at the time, anyway).

Re: Code review can be better

#22

Post by jacobegold » Thu, Aug 21, 2025, 2:00 AM UTC

It's so cool that Git is considering first class change IDs!! That's huge! This sounds similar to what we had at Facebook to track revisions in Phabricator diffs. Curious if anyone knows the best place to read about this?

Re: Code review can be better

#23

Post by loeg » Thu, Aug 21, 2025, 2:01 AM UTC

moonlion_eth wrote: post #20

ersc.io

Say more.

Re: Code review can be better

#24

Post by citizenpaul » Thu, Aug 21, 2025, 2:02 AM UTC

moonlion_eth wrote: post #20

ersc.io

I got into using Jujutsu this year. I'm liking it so far. Is there a beta access in the works?

Re: Code review can be better

#25

Post by faangguyindia » Thu, Aug 21, 2025, 2:04 AM UTC

xeonmc wrote: post #18

faangguyindia wrote: post #11

Essentially, you are turning fork/branch induced changes to "precommit" review like workflow which is great. I was on a lookout for best "precommit" review tool and zeroed on Magit, gitui, Sublime Merge. I am not an emac user, so i'll have to learn this.

In theory this functionality would be best suited as a git subcommand. I suggest `git-precom` for conciseness.

Git already has `git add -p` but demands a lot from user.

Re: Code review can be better

#26

Post by cyberax » Thu, Aug 21, 2025, 2:08 AM UTC

ivanjermakov wrote: post #5

hydroxideOH- wrote: post #2

I use the GitHub Pull Request extension in VSCode to do the same thing (reviewing code locally in my editor). It works pretty well, and you can add/review comments directly in the editor.

It's better, but still quite deep vendor lock-in (in both GitHub and VSCode).

JetBrains IDEs can do the same.

Re: Code review can be better

#27

Post by gatane » Thu, Aug 21, 2025, 2:11 AM UTC

>remote-first web-interface

https://youtu.be/Qscq3l0g0B8

Re: Code review can be better

#28

Post by foota » Thu, Aug 21, 2025, 2:23 AM UTC

tomasreimers wrote: post #16

Just taking a step back, it is SO COOL to me to be reading about stacked pull requests on HN. When we started graphite.dev years ago that was a workflow most developers had never heard of unless they had previously been at FB / Google. Fun to see how fast code review can change over 3-4yrs :)

I miss the fig workflow :-(

Re: Code review can be better

#29

Post by shmerl » Thu, Aug 21, 2025, 2:27 AM UTC

I was recently looking for something that at least presents a nice diff that resembles code review one in neovim.

This is a pretty cool tool for it: https://github.com/sindrets/diffview.nvim

On the branch that you are reviewing, you can do something like this:

:DiffviewOpen origin/HEAD...HEAD

Re: Code review can be better

#30

Post by Pxtl » Thu, Aug 21, 2025, 2:30 AM UTC

faangguyindia wrote: post #25

xeonmc wrote: post #18

Earlier quoted context omitted.

In theory this functionality would be best suited as a git subcommand. I suggest `git-precom` for conciseness.

Git already has `git add -p` but demands a lot from user.

Git demands a lot from user in general.