Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

I couldn't submit a PR, so I got hired and fixed it myself

skeptrune.com

Post reply on HN
Print view View original

91–100 of 218 posts

Re: I couldn't submit a PR, so I got hired and fixed it myself

#91

Post by saagarjha »

wavemode wrote: post #42
bmacho wrote: post #31

Earlier quoted context omitted.

I think we'd probably better off with the previous idea: just work for them for a period.

I'm speaking from the perspective of company A, who needs a feature added to company B's product. They could send their engineers to work for company B, sure, but those engineers' time is still costing money. And those engineers are completely unfamiliar with B's codebase, so they won't work as efficiently. Might as well just pay company B directly for the feature work.

Sometimes Company A is better equipped to fix things in Company B's product than they are themselves.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#92

Post by kQq9oHeAz6wLLS »

naniwaduni wrote: post #86
makeitdouble wrote: post #66

Earlier quoted context omitted.

Except they're working at Amazon now.

tbh you could probably easily have enough gripes with Epic to do this too... but then you'd have to move to Wisconsin.

At least their headquarters are cool

Re: I couldn't submit a PR, so I got hired and fixed it myself

#93

Post by lstamour »

Carrok wrote: post #26
kulahan wrote: post #19

Earlier quoted context omitted.

Clicking through the links in his article, I came across a guy who apparently did the same thing at Apple - he introduced the "auto remove" feature for expired passes added to your wallet, then promptly quit. I had no idea that's how that feature came about, but now I'm going to send a little mental thank you to him every time I get off a plane. That shit was FRUSTRATING.

Oh wow. Guess I need to get a job at Apple just to add a `Mark all as read` button to voicemails.

And the ability to undo deleting voicemails. And record voicemails client side using AI transcription to deliver thnesss

Re: I couldn't submit a PR, so I got hired and fixed it myself

#94

Post by db48x »

theandrewbailey wrote: post #64
SoftTalker wrote: post #28

> I added an AbortController to the debounced search function, so that it aborts any previous queries when a new one is made. This means that the search results are always relevant to what the user is currently typing. To me one of the most annoying things an application can do is go off and do something before I'm done telling it what to do. Filters that apply themselves without an explicit indication that I'm done…

When I implemented search-as-you-type on my blog, I decided to wait for the current search suggestion request to complete before doing a new one. Seemed like a reasonable balance between responsiveness and not overloading the server.

When I implemented one I simply filtered the results that came back from previous requests to see if they matched what the user had typed in the mean time. That way the UI might get relevant results with lower latency than would otherwise be possible with no risk that a non-matching result would show up to confuse the user.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#95

Post by Twirrim »

hsbauauvhabzb wrote: post #78
stevesimmons wrote: post #53

If Google Maps would like to hire me so the km/miles switch can remember I only ever want to see distances in km, my contact details are in my HN profile. I must have changed that back from miles once a fortnight since Google Maps launched 20 years ago. That's 500 times. Totally ridiculous for a company who core goal is profiling their users...

While you’re there can you add a ‘how much I value my time’ input field for tolls? Google suggests I spend $20 through 3 tolls to save a single minute. Constantly. Edit: and while you’re there, move the ‘speed camera ahead, is it still there?’ Dialog. IT COVERS THE DAMN SPEED LIMIT ICON.

And also while you're there, if no car ever in the history of your app goes down the road at the speed limit ever it's a good indication you'll never be able to ever do it at that speed. e.g. small narrow single lane country roads which are only theoretically 60mph roads.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#97

Post by hinkley »

In the reverse situation, I've worked at places where the IP lawyers basically made it impossible to submit PRs to open source code.

But sometimes explaining the exact inputs and the line number where you know the problem is can grease the wheels enough that you can convince someone else to write the fix for you. I didn't technically give you any code. But I did give you free QA.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#98

Post by hinkley »

Sytten wrote: post #96

Good PR, but AbortController doesn't really help with stopping the server from processing the request. I have seen so much of this type of search that just continues processing in the backend even if the client has long gone caring.

There's nobody who really has a library that's set up to feed a sequential task into and have it force a synchronous call to be async with breakpoints to check for early termination.

This seems like a problem Sorhus should have a library for, but he does not.

I've had the conversation too many times in the last couple months about how setTimeout() does absolutely nothing to fix this problem in NodeJS. Even Java had trouble with this and tried to delete the API that seemed like it should support this problem, due to undefined behavior.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#99

Post by throwaway0665 »

Sytten wrote: post #96

Good PR, but AbortController doesn't really help with stopping the server from processing the request. I have seen so much of this type of search that just continues processing in the backend even if the client has long gone caring.

The sever should cancel the request handler when the client drops. Otherwise you're just opening up to accidental DOS.

Re: I couldn't submit a PR, so I got hired and fixed it myself

#100

Post by kshri24 »

stevesimmons wrote: post #53

If Google Maps would like to hire me so the km/miles switch can remember I only ever want to see distances in km, my contact details are in my HN profile. I must have changed that back from miles once a fortnight since Google Maps launched 20 years ago. That's 500 times. Totally ridiculous for a company who core goal is profiling their users...

Another issue with Google Maps is it not showing Plus Codes for some locations that highlight the entire area. If you however place a pin on that location, it provides a Plus Code. Pretty stupid IMHO.

Also it is really, really hard to search for "Nearby" places. Have to do it through "Directions". Really bad UX.

Post reply on HN