Show HN: A GitHub Action that quizzes you on a pull request

Post by klntsky » Wed, Jul 30, 2025, 6:14 AM UTC

Post by shortrounddev2 » Wed, Jul 30, 2025, 1:51 PM UTC

mathieuh wrote: post #30

shortrounddev2 wrote: post #16

Earlier quoted context omitted.

Code review, to me, is not about validating the output. It's about a 2nd set of eyes to check for foot guns, best practice, etc. Code review is one step above linting and one step below unit tests, for me. If someone were to submit this code for review: getUser(id: number): UserDTO { return this.mapToDTO(this.userModel.getById(id)); } and I knew that `userModel` throws an exception when it doesn't find a user (and th…

Depends how good your QA is. Where I am it is terrible so most of the time I spend in “code review” is spent checking out the code locally and testing it myself.

Post by johann8384 » Thu, Jul 31, 2025, 9:05 PM UTC

shortrounddev2 wrote: post #16

sunrunner wrote: post #3

> AI Agents are starting to write more code. How do we make sure we understand what they're writing? This is a good question, but also how do we make sure that humans understand the code that _other humans_ have (supposedly) written? Effective code review is hard as it implies that the reviewer already has their own mental model about how a task could/would/should have been done, or is at the very least building thei…

Code review, to me, is not about validating the output. It's about a 2nd set of eyes to check for foot guns, best practice, etc. Code review is one step above linting and one step below unit tests, for me. If someone were to submit this code for review: getUser(id: number): UserDTO { return this.mapToDTO(this.userModel.getById(id)); } and I knew that `userModel` throws an exception when it doesn't find a user (and th…