Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Why I am tired of writing pull requests

gist.io

Post reply on HN
Print view View original

61–70 of 71 posts

Re: Why I am tired of writing pull requests

#61

Post by ethermal »

aeturnum wrote: post #34
Rayne wrote: post #4

I will pass absolutely no judgement on you because I have no idea who you are, what you do, what the quality of your code/work is, but have you considered that maybe there is actually something wrong with the pull requests? With no references to examples if what you're talking about, it comes off as a bit of a temper tantrum. But that's just what it feels like, but I have no idea because I have nothing to look at to…

Even if he's misguided, he's trying to contribute. His description of someone finding a problem with his code could be written by someone who is a poor coder and doesn't understand why. However, it also doesn't sound like the people who rejected his pulls were very convincing at explaining why. I think the point of the article is that the pull requests he's made came to nothing other than rejection. Nothing about the…

Well said.

Re: Why I am tired of writing pull requests

#62

Post by akavel »

zr52002 wrote: post #35
sciurus wrote: post #27

Earlier quoted context omitted.

I cam here to say this. If something is going to take you more than 15 minutes to do, it's better to coordinate it with the project maintainers first. If it takes you less than 15 minutes, you didn't invest enough to be bitter if your code isn't accepted.

Or you can do that, proposing a trivial enhancement, and have 1) The maintainer tell you "that isn't the designed behavior" (no kidding it doesn't do that now, that's why I want to enhance it!) 2) It marked it as a duplicate of the last handful of people that wanted similar features 3) The ticket closed I'm looking at you, jquery-ui

ad.1: "Every program attempts to expand until it can read mail." :) The argument that the dev doesn't want particular functionality can be perfectly reasonable, and might be a sign that he's even a good one and consciously fights to avoid software bloat...

Re: Why I am tired of writing pull requests

#63

Post by igorgue »

Before going into all the hassle, you should talk in their conversation channels, IRC or mailing list, about your approach and why you want to make this change, get the core developers involved into your development.

I get this every time at work, and sometimes I just don't have time to review something that looks unneeded, from my point of view, and something I can't review, since it's too big of a change.

Re: Why I am tired of writing pull requests

#64

Post by perlpimp »

Engage core developers not the ivory tower bastards. If the core team is not helpful and you think you have a good idea, fork!

As well if you PRs are bug fixes then there is no excuse, if they are feature additions / changes then you might want to invest into a fork, do some cool work and then get noticed. Maybe they'll merge!

I haven't had any trouble getting my PRs accepted takes about a week to three weeks.

Re: Why I am tired of writing pull requests

#65

Post by talmand »

nathan_f77 wrote: post #55

I don't know man, it sounds like your code might not be very good. I'll have to make that assumption if you don't provide any examples, because I've never seen something like that happen. Especially not for 20 straight pull requests. You don't have to look very far to find douchebag programmers, but I've always had friendly encounters on GitHub.

I was going to make a sarcastic comment about the silliness of the thought that since you haven't had the same experience then the author's complaint is invalid.

I don't think it's necessary though.

After all, if it hasn't happened to you then there's no way it has happened to someone else, right?

Plus, your automatic assumption that he's a bad coder is part of the problem the author is complaining about. You know nothing about his code therefore an assumption, positive or negative, is not something you can make.

Re: Why I am tired of writing pull requests

#66

Post by Cyranix »

xrt wrote: post #22
josegonzalez wrote: post #6

That's really too bad. For the record, I've written a couple hundred pull requests - no really! - and those that haven't been accepted have been because - The project is no longer maintained (I fork or rewrite better in this case) - I was actually doing it wrong - My pull didn't have tests and that was the convention (gotta respect conventions) - The author wished to keep my feature out for some random reason, but ei…

Meta: This is a problem w/ HNs layout, but using a fixed pitch line of 144 chars makes the entire page wide enough to require horizontal scrolling. Correction: for Chrome, just the comment, for IE9 the entire page. Is there a bullet list markup?

HN formatting is limited to the following: http://news.ycombinator.com/formatdoc

Because the monospaced format is intended for code, it assumes that lines will be short, so lines longer than ~85 chars get the overflow effect.

Re: Why I am tired of writing pull requests

#68

Post by RegEx »

RegEx wrote: post #60
aaronsw wrote: post #59

Earlier quoted context omitted.

https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d... people.

I have no clue where that commit is coming from. How do I get to it? Thanks.

Apparently the parameter w=1 fixes the white space for the diff in the browser. Is there a way to make the pull request reference that?

Re: Why I am tired of writing pull requests

#69

Post by tedunangst »

RegEx wrote: post #60
aaronsw wrote: post #59

Earlier quoted context omitted.

https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d... people.

I have no clue where that commit is coming from. How do I get to it? Thanks.

It's the same commit you linked to, but ignoring whitespace changes (&w=1, like diff -w).

Re: Why I am tired of writing pull requests

#70

Post by oogali »

Maybe he wants some constructive criticism?

But does he get that a) people are short on time, b) if your code looks/feels like it's too much work to review, the reviewers may procrastinate, and c) no one is actually obligated to accept your unsolicited contribution?

I feel like, pre-Github, this anger would be happen of the course of a few e-mails on a mailing list, and then instantly put in check by a more mature person. There would be no misconceptions in your feelings toward the project, and vice versa -- you could either take it or leave it.

Now, it just builds and festers, until it comes out in a blog post, where probably zero of the original parties even see the concern.

Can we bring back mailing list flames?

Post reply on HN