A project I maintain has an experimental branch that takes most pull requests unless they have obvious issues (which I ask the author to fix). Only things I have not accepted so far were major GUI changes that I considered confusing. (I did accept one change that basically redid the entire GUI because it was awesome). The merges back to the master branch are several months apart, but I think it's a good idea to do deep quality control on the code AFTER it's merged to keep contributors engaged.
Why I am tired of writing pull requests
41–50 of 71 posts
Re: Why I am tired of writing pull requests
#42On the other hand, I've actually taken projects with unmerged pull requests, and pulled them into my own repo to use the new functionality/bug fixes. So they aren't necessarily just sitting there uselessly.
Re: Why I am tired of writing pull requests
#43Sounds like a case of entitlement. Why would you waste your time working on something and not know if it is wanted or not?
It's your fault for not planning ahead.
Re: Why I am tired of writing pull requests
#44Sounds like a case of entitlement. Why would you waste your time working on something and not know if it is wanted or not?
It's your fault for not planning ahead.
Re: Why I am tired of writing pull requests
#45Ah the peril of general claims with no specific examples.
Re: Why I am tired of writing pull requests
#46He describes a social problem which is very dependent on the actual maintainers, but blames it on the mechanism. Yeah, some projects have prickly/uncooperative maintainers... so what? That's true regardless of the collaboration mechanism used, and there's no obvious reason why pull requests make this problem worse than other mechanisms. Indeed, I would guess that pull requests make things better than many other metho…
I didn't read that in his post. He seemed mostly to be troubled by how easily the process can be derailed by going off topic on getting lost in details.
Re: Why I am tired of writing pull requests
#47[deleted]
Re: Why I am tired of writing pull requests
#48Earlier quoted context omitted.
That's not always the case, and sometimes if you don't know the language very well - in my case, Ruby - then certain patterns aren't available to you and it looks hokey without you realizing it.
Completely forgivable. This pull request[0], on the other hand, is probably more along the lines of what mirsadm was thinking of. [0]: https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...
That's the douchiest diff I've seen yet. I've seen diffs where a shitty and misconfigured IDE had reformatted half the code and the guy hadn't reviewed his diff, but "incidentally spaces to tab" is the biggest "fuck you reviewer" I can think of.
Re: Why I am tired of writing pull requests
#49The good thing about this post is that it reminded me to be better at expressing my gratitude when finding solutions to my problems in pull requests. This makes the person who made the pull request understand that the work was appreciated even if it wasn't pulled and I would imagine that a request with many "thank you" comments would be more likely to be pulled.
Re: Why I am tired of writing pull requests
#50This is not really the norm, but it does happen every now and then that pull requests are refused cause "they'll do it themselves". At which point you may think "my code sucks that much?"
Then when they do, they just copy your pull and put no credits, and there, you understand. Classic :P
But then again, it's not the norm. I don't give a fuck about pull requests or anything similar anymore since a long, long time. I just put it there for anyone who wanna take stuff, but the fixes are generally for my own use. And I'm usually too lazy to fork and fix the world, anyway.