Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Why I am tired of writing pull requests

gist.io

Post reply on HN
Print view View original

21–30 of 71 posts

Re: Why I am tired of writing pull requests

#22

Post by xrt »

josegonzalez wrote: post #6

That's really too bad. For the record, I've written a couple hundred pull requests - no really! - and those that haven't been accepted have been because - The project is no longer maintained (I fork or rewrite better in this case) - I was actually doing it wrong - My pull didn't have tests and that was the convention (gotta respect conventions) - The author wished to keep my feature out for some random reason, but ei…

Meta: This is a problem w/ HNs layout, but using a fixed pitch line of 144 chars makes the entire page wide enough to require horizontal scrolling. Correction: for Chrome, just the comment, for IE9 the entire page. Is there a bullet list markup?

Re: Why I am tired of writing pull requests

#23

Post by jmathes »

I'm with you. I added parallel test execution to PHPUnit, which its maintainers have been promising since 2005. When I started writing it, they found me and encouraged me along. So I spent two weeks on it at 16 hours a day. When I was done, they invented reasons not to merge. When I was done fixing the reasons they had invented, they said they didn't want to merge it because they were going to write it themselves.

Re: Why I am tired of writing pull requests

#26

Post by hnruss »

This is highly subjective. Every project and maintainer is different.

Personally, I try to be 100% positive whenever I interact with anyone who has put their time and energy into improving a project that I maintain because I am 100% grateful for their effort. If I think that their code could be better in some way, I make that suggestion to them in a positive way. If they don't want to take my advice, then I'll merge their request and make the improvements myself. Heck, even if their code breaks something I'll still merge it in-- then fix it myself while retaining the intention of their code.

Being negative towards contributors is counter-productive.

Re: Why I am tired of writing pull requests

#27

Post by sciurus »

simanyay wrote: post #12

The first thing you should always do is create a ticket. There you can discuss if its worth spending time on a patch and what the best implementation could be. Pull requests that come up out of nowhere usually end up in the end of maintainers' queue. Or you can continue calling people who maintain free and open source projects in their spare time douchebags and neckbeards.

I cam here to say this. If something is going to take you more than 15 minutes to do, it's better to coordinate it with the project maintainers first. If it takes you less than 15 minutes, you didn't invest enough to be bitter if your code isn't accepted.

Re: Why I am tired of writing pull requests

#28

Post by karlshea »

simanyay wrote: post #12

The first thing you should always do is create a ticket. There you can discuss if its worth spending time on a patch and what the best implementation could be. Pull requests that come up out of nowhere usually end up in the end of maintainers' queue. Or you can continue calling people who maintain free and open source projects in their spare time douchebags and neckbeards.

Or you can be like OpenLayers and just ignore a ticket with almost a dozen comments and two working patches and a pull request!

Sometimes people just don't want your code.

Re: Why I am tired of writing pull requests

#30

Post by dumbluck »

josegonzalez wrote: post #6

That's really too bad. For the record, I've written a couple hundred pull requests - no really! - and those that haven't been accepted have been because - The project is no longer maintained (I fork or rewrite better in this case) - I was actually doing it wrong - My pull didn't have tests and that was the convention (gotta respect conventions) - The author wished to keep my feature out for some random reason, but ei…

Agreed. I have a few projects now I've not had time to integrate patches for and they've waited months. I know they are using the patches so they aren't waiting on me, and no one else has complained so it isn't on my priority list. either. In the meantime, I'm submitting pull requests to github projects that I am getting paid at work to work on, some accepted, some denied.
Post reply on HN