We do a lot of PRs as well. Most are automatically created and pushed.
1,145 pull requests per day
21–30 of 91 posts
Re: 1,145 pull requests per day
#22The comments so far are surprising. Yea counting PRs and lines of code isn’t impressive, and yes you may also do them at your own company. Any engineer will tell you, if you push code often and continuously move it to production, regression is inevitable. In finance, at a scale that stripe operates, not making mistakes is very critical. Being able to do what the articles describes is very impressive in any engineering organization. Being able to do that as Stripe is even more impressive.
Re: 1,145 pull requests per day
#23How many of those people are actually working on the core payments flow that they're measuring the uptime of?
I'm sure most people are working on some settings UI, fraud or risk tools, etc.
Re: 1,145 pull requests per day
#24Impact is what matters. Not PRs/diffs or LoC. These are PHB KPIs. Basically, they're bragging about how busy their engineers are making themselves look.
PHB? Pointy haired boss? My first time seeing this.
Re: 1,145 pull requests per day
#25Having minute of downtime per year is quite a big tradeoff.
It makes sense for Stripe, they would lose lot of money when not operating. But in smaller companies you can choose to take more downtime to reduce engineering time.
Instead of skirting around doing gradual data transformations on live data, you could take service offline and do all of it once.
Re: 1,145 pull requests per day
#26Re: 1,145 pull requests per day
#27Is there any description of Stripe's architecture and infrastructure somewhere published?
Re: 1,145 pull requests per day
#28I hope they're not using GitHub; my inbox is unusable from GitHub talking to itself and choosing to stand next to me at the party, and we're not [currently] doing anywhere near that volume I've gotten some handle on it by some gmail filters but holy hell if you want to make sure I don't see something, smuggle it in a From:github.com email With the new Copilot makes PRs, I could easily imagine getting to 1145 PRs per…
FWIW you can go to settings on GitHub and select what you get emails about. There may even be a digest option such that you get one email per day with all the stuff you would’ve received individual emails about IIRC.
Re: 1,145 pull requests per day
#29Is counting the number of pull requests a useful measure of engineering performance ergo product performance and company perf? Isn't it more like a BS counter that keep incrementing and that is indicative of churn but nothing else reliably. One of the most low effort, easily to game metric that can be skewed to show anything that the user wants to show.
In my org they count both the number of pull requests, and the number of comments you add to reviews. Easily gamed, but that's the performance metric they use to compare every engineer now.
good god, i would quit in a heartbeat.
Re: 1,145 pull requests per day
#30[dead]