31–40 of 154 posts
Earlier quoted context omitted.
They want you to just submit a PR with a test that, if passed, would indicate the problem for you is fixed.
What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue
I like this. I am imagining a companion extension for chrome/ff that uses you-get as a backend to implement it in a seamless way. Forward thinking idea: imagine going on youtube and have you-get extension bypass the youtube player and playing the content directly without ads. When I say youtube I might also say any other platform.
https://addons.mozilla.org/en-US/firefox/addon/faststream/?u...
Can someone explain why this is better than yt-dlp
Earlier quoted context omitted.
Good chance you wouldn't be writing good bug reports either, then. Github issues have enough noise that a first-pass filter like this feels like a good idea, even if it has some false positives.
I fail to see the logic in your comment. Just another case of Goodhart's law.
Seems to make sense
Earlier quoted context omitted.
They want you to just submit a PR with a test that, if passed, would indicate the problem for you is fixed.
I kind of like this. It's a more formal proof of concept. You prove the bug exists by writing a failing test. If they cannot construct a failing test then it's either too hard to mock or reproduce (and therefore maybe not even worth fixing, for a free tool), or it's impossible because it's not a bug. Frees up maintainer time from dealing with reports that aren't bugs.
Or, you know, the user is not a developer. Or is unfamiliar with Python, or their test suite, or git, or…
It is perfectly possible to be good at reporting bugs but be incapable of submitting pull requests.
Earlier quoted context omitted.
What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue
Did you (or anyone) in this thread look to see exactly what they are looking for with their provided examples? https://github.com/soimort/you-get/pull/2680/commits/313b8d2... You do not need to know Python deeply to construct what they are expecting. They’re not actually looking for a unit test or something.
I did. And I looked at all examples of “good commits”, not just the trivial ones.
https://github.com/soimort/you-get/pull/2685/files
That’s already complex for someone unfamiliar with the software (which might nonetheless be able to open a competent bug report).
Earlier quoted context omitted.
What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue
Good chance you wouldn't be writing good bug reports either, then. Github issues have enough noise that a first-pass filter like this feels like a good idea, even if it has some false positives.
What you're saying is even worse, since you’re implying someone could be an expert computer programmer or power user, but because they’re unfamiliar with the specific language this project chose, they are incapable of making good bug reports. That makes no sense.
It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.
`you-get` is currently experimenting with an aggressive approach to handling issues. Namely, a bug report must be addressed with some code via a pull request.
Maybe they got too much spam.
By the way, `tests/test.py` seems to just run the extractors against various websites directly. I can't find where it's mocking out network requests and replies. Maybe this is to simplify the process for people creating pull requests?
It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.
The Chinese version of the text has an extra header line that translates to "to prevent abuse via GitHub Issues, we are not accepting general issues". An earlier commit has this for the English text: `you-get` is currently experimenting with an aggressive approach to handling issues. Namely, a bug report must be addressed with some code via a pull request. https://github.com/soimort/you-get/commit/75b44b83826b3c2d9a.…
Though what I'm unsure how to deal with is legitimate users being idiotic. For example, recently one issue was opened that asked where the source code was. Not only was there a directory named "src" but there were some links in the readme to specific parts. While I do appreciate GitHub and places like hugging face [0], there are a lot of very aggressive and demanding noobs.
I'd like ways to handle them better.... I'm tired of people yelling at me because 5 year old research code no longer works out of the box or because you've never touched code before.
[0] check any hugging face issue and you'll see far more spam. Same accounts will open multiple issues that just barate owners and hugging face makes it difficult to report these accounts.