Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

You-get: Dumb downloader that scrapes the web

github.com

Post reply on HN
Print view View original

11–20 of 154 posts

Re: You-get: Dumb downloader that scrapes the web

#11

Post by sigseg1v »

kylecazar wrote: post #7
politelemon wrote: post #2

It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.

They want you to just submit a PR with a test that, if passed, would indicate the problem for you is fixed.

I kind of like this. It's a more formal proof of concept. You prove the bug exists by writing a failing test. If they cannot construct a failing test then it's either too hard to mock or reproduce (and therefore maybe not even worth fixing, for a free tool), or it's impossible because it's not a bug. Frees up maintainer time from dealing with reports that aren't bugs.

Re: You-get: Dumb downloader that scrapes the web

#12

Post by tylerchilds »

wccrawford wrote: post #9
politelemon wrote: post #2

It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.

As the other commenter said, they want a failing test, not a fix. A detailed description of the encountered problem; At least one commit, addressing the problem through some unit test(s). Examples of good commits: #2675, #2680, #2685 "Addressing" is probably a bad word to use here. "Demonstrating" would have been better, IMO.

the most expensive piece of writing software is scoping work.

i’m almost tempted to add a test suite just to give people more agency over my output because right now i’m only soliciting feedback in person to cut down on internet bullshit, like what happened to xz-utils

Re: You-get: Dumb downloader that scrapes the web

#13

Post by uniqueuid »

KTibow wrote: post #3

Can someone explain why this is better than yt-dlp

That's an interesting question. They only depend on a single library, but I wonder how much code is really their own. I found it curious, for example, that there is a dedicated mp4 joiner (I mean, if you already have ffmpeg, there is probably no way you can do it better yourself).

https://github.com/soimort/you-get/blob/develop/src/you_get/...

Re: You-get: Dumb downloader that scrapes the web

#14

Post by Filligree »

thangngoc89 wrote: post #10
kylecazar wrote: post #7

Earlier quoted context omitted.

They want you to just submit a PR with a test that, if passed, would indicate the problem for you is fixed.

What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue

Good chance you wouldn't be writing good bug reports either, then. Github issues have enough noise that a first-pass filter like this feels like a good idea, even if it has some false positives.

Re: You-get: Dumb downloader that scrapes the web

#15

Post by thih9 »

politelemon wrote: post #2

It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.

It’s relatively easy to write a failing test and it massively cuts down the work related to moderating issues. Also, reduces the danger of github issues turning into a support forum.

If this results in the project being easier to maintain and being maintained longer, then I’m fine with this.

Re: You-get: Dumb downloader that scrapes the web

#16

Post by seneca »

thih9 wrote: post #15
politelemon wrote: post #2

It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.

It’s relatively easy to write a failing test and it massively cuts down the work related to moderating issues. Also, reduces the danger of github issues turning into a support forum. If this results in the project being easier to maintain and being maintained longer, then I’m fine with this.

> It’s relatively easy to write a failing test and it massively cuts down the work related to moderating issues.

Relative to what? Learning someone else's code base well enough to write a useful test is not trivial.

It's not a bad method, but the vast majority of users won't be capable of writing a test that encapsulates their issue.

Re: You-get: Dumb downloader that scrapes the web

#17

Post by js8 »

thangngoc89 wrote: post #10
kylecazar wrote: post #7

Earlier quoted context omitted.

They want you to just submit a PR with a test that, if passed, would indicate the problem for you is fixed.

What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue

The same thing that happens if the author of the OSS you use doesn't know English.

Re: You-get: Dumb downloader that scrapes the web

#18

Post by dartos »

thangngoc89 wrote: post #10
kylecazar wrote: post #7

Earlier quoted context omitted.

They want you to just submit a PR with a test that, if passed, would indicate the problem for you is fixed.

What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue

Then you don’t get to contribute bug reports.

Perfectly fine rule for a maintainer to have.

Re: You-get: Dumb downloader that scrapes the web

#19

Post by probably_wrong »

onionisafruit wrote: post #8
politelemon wrote: post #2

It seems they do not want you to report an issue without an accompanying fix for it. > If you would like to report a problem you find when using you-get, please open a Pull Request, which should include [snip] Can't say I've encountered this before.

Interesting. I like the idea of encouraging people to try creating a test or even a whole fix, but saying that’s all you will accept is a bit much. On the other hand, I’m not doing the work to maintain you-get. I don’t know what they deal with. This may be an effective way to filter a flood of repetitive issues from people who don’t know how to run a command line program.

I believe there are two extremes. On one end you get a bunch of repetitive non-issues, while on the other end you only get issues about (say) bugs in FreeBSD 13.3 because only hard-core users have the skills and patience to follow THE PROCESS.

I know how to make an isolated virtual environment, install the package, make a fork, create a test and make a PR. But I don't know whether I care enough about a random project to actually do it.

Re: You-get: Dumb downloader that scrapes the web

#20

Post by papichulo2023 »

Filligree wrote: post #14
thangngoc89 wrote: post #10

Earlier quoted context omitted.

What happens if you don’t know Python? Python is a relatively easy language to learn but no way I’m gonna learn Python just to report an issue

Good chance you wouldn't be writing good bug reports either, then. Github issues have enough noise that a first-pass filter like this feels like a good idea, even if it has some false positives.

I fail to see the logic in your comment. Just another case of Goodhart's law.
Post reply on HN