I’ve always thought that one reason it became so well known is that it sounds kind of badass. A shoal is, of course, a shallow bit of water, general associated with running aground and that sort of thing. Black-Shoals sounds like an area where Blackbeard the pirate will hang out steal all your stuff if you get stuck. I’ve always thought quants secretly want to be pirates, but of course the era of going around pirating is over, so they learned how to do it on the market instead.
In the time of piracy, they could probably have been navigators, that job was pretty mathy. The would have presumably gone around the Black-Shoals.