Winamp Legacy player source code • Hacker News Board

Re: Winamp Legacy player source code

#81

Post by opan » Tue, Sep 24, 2024, 3:36 PM UTC

Not open source, not free software. Restrictions in license found here for those curious:

https://github.com/WinampDesktop/winamp/blob/community/LICEN...

Re: Winamp Legacy player source code

#82

Post by f1shy » Tue, Sep 24, 2024, 3:39 PM UTC

I was expecting to see some comment about the quality of the code. How clean (or not) it is.

I was personaly hopping a much more ordered and clean codebase.

Re: Winamp Legacy player source code

#83

Post by mihaitodor » Tue, Sep 24, 2024, 3:39 PM UTC

Wish they bothered to preserve the commit history... Can't imagine anything sensitive in there that they couldn't share.

Re: Winamp Legacy player source code

#84

Post by thomastjeffery » Tue, Sep 24, 2024, 3:39 PM UTC

chrisfinazzo wrote: post #60

thomastjeffery wrote: post #34

Earlier quoted context omitted.

That still contradicts the license as written. > No Forking: You may not create, maintain, or distribute a forked version of the software. There is no meaningful difference between the words "patch" and "fork"; and the act of creating an edited codebase is explicitly disallowed. If that isn't what they want, then they had better write more clearly.

English is a stupid language ¯\_(ツ)_/¯

You can't blame this one on English.

Before the ambiguity of language can get in the way, there has to be a coherent idea that you want to express in the first place.

This license explicitly contradicts itself. It says you are encouraged to contribute changes to the source, and you may not share changes to the source with anyone ever.

Re: Winamp Legacy player source code

#85

Post by JosephRedfern » Tue, Sep 24, 2024, 3:39 PM UTC

There is some pretty creative swearing throughout this codebase - very entertaining!

Re: Winamp Legacy player source code

#86

Post by Linkd » Tue, Sep 24, 2024, 3:40 PM UTC

Are there any tools that can receive an entire code base like this, then analyze and answer questions about the code, structure, functionality?

Re: Winamp Legacy player source code

#87

Post by mihaitodor » Tue, Sep 24, 2024, 3:41 PM UTC

jb1991 wrote: post #68

thefourthchime wrote: post #64

I have a little history with Winamp. I wrote a popular plugin for it back in the day. This is the source code for Winamp 3, which is a total rewrite of winamp 2 in C++. In my opinion, it was overcomplicated and over-architected. The original source code by Justin Frankel in C.

Is Frankel's original code anywhere? I do recall him saying once that he preferred C++ over C but used C++ as simply C with classes. Frankel is a hero of mine.

I think there was a copy of it buried somewhere in the comments here: https://news.ycombinator.com/item?id=29379346

Re: Winamp Legacy player source code

#88

Post by 29athrowaway » Tue, Sep 24, 2024, 3:43 PM UTC

There is an open source clone of Winamp called XMMS.

Sonique and Foobar2000 were also venerable players of that era.

Re: Winamp Legacy player source code

#89

Post by davidpfarrell » Tue, Sep 24, 2024, 3:43 PM UTC

The best thing we can do for the future of the project is to NOT engage with the project at this time ... Even just cloning the project into your private workspace to review / compile is giving more engagement than their current licensing stance warrants.

I'll check again when an HN post comes out stating they've changed their licensing stance - Until then, closing this tab and forgetting about it ...

Re: Winamp Legacy player source code

#90

Post by johnchristopher » Tue, Sep 24, 2024, 3:44 PM UTC

Which winamp is it ? Version 2 ? Version 3 with the wasabi (?) engine ? Or version 5 ?