Good refactoring vs. bad refactoring

Post by skybrian » Tue, Aug 20, 2024, 4:33 PM UTC

Jean-Papoulos wrote: post #40

skybrian wrote: post #18

Earlier quoted context omitted.

Making analogies like this doesn't prove anything, they're just suggestive. All I'm getting out of this is that you think for loops are old-fashioned.

That's because they are. Functional code is more readable. And if you look back, basically all advances in programming languages have been about "making stuff more readable". Thus, for loops (for this usage) are "old".

Post by Joker_vD » Tue, Aug 20, 2024, 4:43 PM UTC

Jean-Papoulos wrote: post #40

skybrian wrote: post #18

Earlier quoted context omitted.

Making analogies like this doesn't prove anything, they're just suggestive. All I'm getting out of this is that you think for loops are old-fashioned.

That's because they are. Functional code is more readable. And if you look back, basically all advances in programming languages have been about "making stuff more readable". Thus, for loops (for this usage) are "old".

    name: R.pipe(R.prop('name'), R.toUpper),
    age: R.prop('age'),
    isAdult: R.always(true)

    name: user.name.toUpperCase(),
    age: user.age,
    isAdult: true

Post by vips7L » Tue, Aug 20, 2024, 5:34 PM UTC

Terr_ wrote: post #74

vips7L wrote: post #70

Earlier quoted context omitted.

With proper OO you could still implement that on the user object. boolean isAdult() { return this.age >= this.location.ageOfAdulthood(); // or this.location.isAdult(this.age); pick your poison! } …anyway it’s just an example of how to introduce OO concepts. As everything in programming it depends

Just having some fun with bikeshedding here: Yeah, that could work but IMO in a big/international system the responsibility should ideally live elsewhere, since: * You may need to determine adulthood for a different jurisdiction than where the person currently resides. Their citizenship may be elsewhere, or you may be running a report that expects "adulthood" to be by some other region's standards, etc. * Sometimes t…

    class User {
        // Convenience function to check if the user is an adult in their current location
        boolean isAdult() {
            return this.location.isAdult(this);
        }


        boolean isOfDrinkingAge() {
            return this.location.isOfDrinkingAge(this);
        }
    }

    interface Location {
        boolean isAdult(User u);
        boolean isOfDrinkingAge(User u);
    }

    class WeirdLawsLocation implements Location {
        boolean isAdult(User u) {
            return switch (u.gender()) {
                case MALE -> u.age() >= 16;
                case FEMALE -> u.age() >= 18;
            }     
        }

        boolean isOfDrinkingAge(User u) {
            return u.age() >= 21
        } 
    }

    class SwedenLocation implements Location {
        boolean isAdult(User u) {
            return u.age() >= 18;
        }

        boolean isOfDrinkinAge(User u) {
            return u.age() >= 18;
        }
    }
    var sweden = new SwedenLocation();
    sweden.isOfDrinkingAge(user);

Post by sevnin » Tue, Aug 20, 2024, 6:36 PM UTC

FooBarBizBazz wrote: post #69

sevnin wrote: post #68

Earlier quoted context omitted.

My man, thanks for the explanation but I understand the concept I just didn't agree on definition.

Sure. Whenever you post on a forum it's half for anybody else reading, right? I just thought it was interesting to consider the underlying metaphor; maybe people don't think about it. Metaphors, connotations, etymologies -- I find these interesting.

Post by vips7L » Tue, Aug 20, 2024, 7:13 PM UTC

vips7L wrote: post #75

Terr_ wrote: post #74

Earlier quoted context omitted.

Just having some fun with bikeshedding here: Yeah, that could work but IMO in a big/international system the responsibility should ideally live elsewhere, since: * You may need to determine adulthood for a different jurisdiction than where the person currently resides. Their citizenship may be elsewhere, or you may be running a report that expects "adulthood" to be by some other region's standards, etc. * Sometimes t…

Yes this is just extreme bike-shedding at this point. But none of this is impossible with more OO principles, like interfaces: class User { // Convenience function to check if the user is an adult in their current location boolean isAdult() { return this.location.isAdult(this); } boolean isOfDrinkingAge() { return this.location.isOfDrinkingAge(this); } } interface Location { boolean isAdult(User u); boolean isOfDrink…