21–30 of 101 posts
I can't believe you hardcoded this for MySQL instead of using PHP's excellent and versatile PDOs, and I can't believe the 10k line count. Gosh. Is "de-engineering" a suitable term here? Thumbs up for open sourcing your work, though.
Make a pull request, sir.
What exactly did you dislike about CodeIgniter? For me CodeIgniter is probably what I'd use if I had to go back to making PHP applications so I'd like to hear any reasons you had against it.
//CI Class Load Example:
$this->load->library('example'); $this->example->something();
//Raw PHP Class Load Example:
$this->example = new Example(); $this->example->something();
As you can see, the latter is a little more obvious about what is going on.
Just as a quick look, this thing is riddled w/ potential sql injections..a number of unchecked/unescaped uri controlled variables. In some cases there's validation of numerics w/ +=0, but in many cases (e.g. $sort_col) there's none.
If I'm wrong, please do let me know!
Just as a quick look, this thing is riddled w/ potential sql injections..a number of unchecked/unescaped uri controlled variables. In some cases there's validation of numerics w/ +=0, but in many cases (e.g. $sort_col) there's none.
I remember writing invoicing systems like this. Then I realized I probably shouldn't reinvent the wheel or break GAAP. :/
Just as a quick look, this thing is riddled w/ potential sql injections..a number of unchecked/unescaped uri controlled variables. In some cases there's validation of numerics w/ +=0, but in many cases (e.g. $sort_col) there's none.
you mean you shouldn't trust user input?
Earlier quoted context omitted.
No I'm serious here, renownedmedia. Don't disregard my rant with a silly downvote, but do instead indulge yourself in the PDO methods instead of painting yourself and your projects into corners: http://php.net/manual/en/book.pdo.php
What makes you think he was the one who downvoted you? You could easily have asked him about his technical decisions without being a jerk. Besides, this was a personal project, probably created without the intention of eventually open sourcing it. If he only ever intended to use MySQL, and portability across RDBMS systems wasn't a goal, then it's fine as it is.
Earlier quoted context omitted.
you mean you shouldn't trust user input?
The arguments to controller methods (in CI) are passed through some regular expressions. CI goes as far as to destroy all GET variables (which I highly disagree with).
I remember writing invoicing systems like this. Then I realized I probably shouldn't reinvent the wheel or break GAAP. :/
Yeah, there is a ton of competition. I started building this without having done proper research.
Otherwise, you get this ugly term: embezzlement.
But kudos for opensourcing it and standing up to criticism from hecklers like me.