Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

WireGuard-rs – Official Rust implementation of WireGuard

git.zx2c4.com

Post reply on HN
Print view View original

11–20 of 29 posts

Re: WireGuard-rs – Official Rust implementation of WireGuard

#11

Post by palunon »

freeopinion wrote: post #9
api wrote: post #6

Earlier quoted context omitted.

Wireguard is a pretty fixed and simple standard. Nothing needs to happen.

So the "tcp: fix incorrect undo caused by DSACK of TLP retransmit" done five weeks ago for the Linux kernel didn't need to happen for the Rust implementation?

I don't think this commit has anything to do with wireguard. It's a fix of a bug in the kernel TCP stack, which wireguard doesn't use. (Beware, the wireguard-linux repo is a "fork" of the complete linux kernel)

And even if it did, a userland TUN implementation of the wireguard protocol probably doesn't have the same bugs as the linux kernel one.

Re: WireGuard-rs – Official Rust implementation of WireGuard

#12

Post by verandaguy »

api wrote: post #6
Aerbil313 wrote: post #5

Earlier quoted context omitted.

Cause it presumably has to be compatible with Wireguard upstream?

Wireguard is a pretty fixed and simple standard. Nothing needs to happen.

Sure, the standard is relatively straightforward, but the implementations have to keep up with their environment. Wireguard in Linux has to keep up with changes in the kernel to a degree, for example.

Re: WireGuard-rs – Official Rust implementation of WireGuard

#13

Post by mhio »

api wrote: post #4
perrohunter wrote: post #3

Earlier quoted context omitted.

Looks like it? 4 years old commits

Why is that a bad thing? Maybe it just works and doesn't need further changes.

How do rust projects work over rust versions?

Is rust stable enough from 20-24 that the project would likely remain in a state to compile on a new rust tool chain? Do "Editions" completely solve this?

Re: WireGuard-rs – Official Rust implementation of WireGuard

#14

Post by mmastrac »

mhio wrote: post #13
api wrote: post #4

Earlier quoted context omitted.

Why is that a bad thing? Maybe it just works and doesn't need further changes.

How do rust projects work over rust versions? Is rust stable enough from 20-24 that the project would likely remain in a state to compile on a new rust tool chain? Do "Editions" completely solve this?

Pretty much. I've had a great deal of luck rebuilding older projects. You can lock your toolchain as an added protection, but `cargo clippy --fix` is often enough to fix 90% of those.

I think the only time I really struggled with a toolchain upgrade was with one of the crypto libraries that was bringing in a broken version of some SIMD code (cannot remember the exact details).

For kicks I cloned and build this with Rust 1.80 and it built just fine (a few reasonable warnings), and even bumped the edition up to 2021. The README suggests you need nightly but that's clearly not the case.

EDIT: the Rust code is actually unsoundly using MaybeUnit in a few places.

Re: WireGuard-rs – Official Rust implementation of WireGuard

#15

Post by [deleted] »

mhio wrote: post #13
api wrote: post #4

Earlier quoted context omitted.

Why is that a bad thing? Maybe it just works and doesn't need further changes.

How do rust projects work over rust versions? Is rust stable enough from 20-24 that the project would likely remain in a state to compile on a new rust tool chain? Do "Editions" completely solve this?

[deleted]

Re: WireGuard-rs – Official Rust implementation of WireGuard

#16

Post by scubbo »

saurik wrote: post #7

If anyone needs one of these, there is an UNofficial implementation by Cloudflare, which is used in Warp. https://github.com/cloudflare/boringtun

A high density of "things that Hacker News people dislike" in a single comment - bold!

(FWIW I personally really like Cloudflare and think that a lot of their hate is unjustified. Warp is probably a good place for a new-to-programming person to start, but doesn't offer any functionality that makes me want to transition away from my already-customized shell)

Re: WireGuard-rs – Official Rust implementation of WireGuard

#18

Post by gpm »

saurik wrote: post #7

If anyone needs one of these, there is an UNofficial implementation by Cloudflare, which is used in Warp. https://github.com/cloudflare/boringtun

I am hesitant to use this, it appears to be basically unmaintained

https://github.com/cloudflare/boringtun/issues/344

https://github.com/cloudflare/boringtun/issues/407

Re: WireGuard-rs – Official Rust implementation of WireGuard

#19

Post by wmf »

scubbo wrote: post #16
saurik wrote: post #7

If anyone needs one of these, there is an UNofficial implementation by Cloudflare, which is used in Warp. https://github.com/cloudflare/boringtun

A high density of "things that Hacker News people dislike" in a single comment - bold! (FWIW I personally really like Cloudflare and think that a lot of their hate is unjustified. Warp is probably a good place for a new-to-programming person to start, but doesn't offer any functionality that makes me want to transition away from my already-customized shell)

The Cloudflare Warp VPN is not the same as the Warp terminal.
Post reply on HN