This is one of the absolutely classic cases where I'd expect a very small amount of property-based testing to flush out a very large number of bugs, by the way.
Show HN: WAL Implementation in Golang
11–20 of 30 posts
Re: Show HN: WAL Implementation in Golang
#12golangci-lint finds three errors in rebuf.go at commit 615209d. It's never safe to write golang without the linters!
Re: Show HN: WAL Implementation in Golang
#13in line 200 of rebuf.go, did you mean to return err (instead of returning nil even when an error occurs)?
Re: Show HN: WAL Implementation in Golang
#14Cool library. Two small generic Go library issues:
1. The rebuf.Init function panics. I almost never want a library to call panic, and when it does, I want the library function to denote that. The convention I’ve seen most often is to start the function name with Must, so MustInit instead of Init. In this case though, I think it’d be safe to be a little more lenient in what you accept as input and trim the trailing slash.
2. I never (not almost, actually never) want library code to call any of the fmt.Print functions unless the library is explicitly for writing output, or that behavior is strictly opt in. If the library really must print things, it should take a user supplied os.Writer and write to that. Let the user control what gets printed or not.
Re: Show HN: WAL Implementation in Golang
#15Having written one of these, a few optimizations will go a long way:
1. syscall.Iovec allows you to build up multiple batches semi independently and then write them all in a single syscall and sync the file with the next one. It is a good basis for allowing multiple pending writes to proceed in independent go routines and have another one have all the responsibility for flushing data.
2. It is better to use larger preallocated files than a bunch of smaller ones, along with batching, fixed size headers and padding write blocks to a known size. 16 megabytes per wal and a 128 byte padding worked well for me.
3. Batching writes until they reach a max buffer size and/or a max buffer age can also massively increase throughput. 1 megabyte max pending write or 50 ms time passed worked pretty well for me for batching and throughput to start with, then dynamically tuning the last bound to the rolling average of the time the last 16 write+sync operations (and a hard upper bound to deal with 99th percentile latency badness) worked better. Bounded channels and a little clever math makes parallelizing all of this pretty seamless.
4. Mmap'ing the wals makes consistency checking and byte level fiddling much easier on replay. No need to seek or use a buffered reader, just use slice math and copy() or append() to pull out what you need.
Re: Show HN: WAL Implementation in Golang
#16Having some tests is necessary to avoid mostly of the bugs that other comments are pointing out.
Perhaps it's just me, but I don't trust code that hasn't been tested.
Re: Show HN: WAL Implementation in Golang
#17Cool library. Two small generic Go library issues: 1. The rebuf.Init function panics. I almost never want a library to call panic, and when it does, I want the library function to denote that. The convention I’ve seen most often is to start the function name with Must, so MustInit instead of Init. In this case though, I think it’d be safe to be a little more lenient in what you accept as input and trim the trailing s…
1. You're right! Will fix it to handle this as well as the support for relative directories
2. Yes, Will integrate a logging library instead of fmt (https://github.com/uber-go/zap)
Re: Show HN: WAL Implementation in Golang
#18Having written one of these, a few optimizations will go a long way: 1. syscall.Iovec allows you to build up multiple batches semi independently and then write them all in a single syscall and sync the file with the next one. It is a good basis for allowing multiple pending writes to proceed in independent go routines and have another one have all the responsibility for flushing data. 2. It is better to use larger pr…
Thanks! Could you please point me to a reference for (1)
etcd/wal actually does do preallocations (https://github.com/etcd-io/etcd/blob/24e05998c68f481af2bd567...)
Yet to implement max buffer age! Any references for this would be bomb!
Is mmap() really needed here? Came across a similar project that does this? Really gotta dig deep here! https://github.com/jhunters/bigqueue
Re: Show HN: WAL Implementation in Golang
#19This is one of the absolutely classic cases where I'd expect a very small amount of property-based testing to flush out a very large number of bugs, by the way.
Will do! Thanks for the comment
Re: Show HN: WAL Implementation in Golang
#20Having some tests is necessary to avoid mostly of the bugs that other comments are pointing out. Perhaps it's just me, but I don't trust code that hasn't been tested.
Yet to implement linting and unit tests. This is kind of a rough draft/v0