GCC 14 Boasts Nice ASCII Art for Visualizing Buffer Overflows • Hacker News Board

Re: GCC 14 Boasts Nice ASCII Art for Visualizing Buffer Overflows

#51

Post by spookie » Thu, Apr 04, 2024, 7:39 AM UTC

OneOfTheMicahs wrote: post #46

legobmw99 wrote: post #16

Earlier quoted context omitted.

How well do screen readers parse other compiler errors? This isn’t me trying to be snarky, I actually have no idea! Reading a C++ template error is hard enough as a sighted person

They read every symbol or character that is displayed. Normal errors are verbose but at least they have meaning. Pictures that use ascii or other characters end up having all the symbols read too because there are no semantics associated with the picture. I like to ask this question on posts about new libraries or developer tools, because most developers don't consider the accessibility of the features they're buildi…

A good thing about emojis is that they'll be read correctly. Huge win for accessibility, they are.

Re: GCC 14 Boasts Nice ASCII Art for Visualizing Buffer Overflows

#52

Post by dmalcolm » Thu, Apr 04, 2024, 2:59 PM UTC

ephaeton wrote: post #49

dmalcolm wrote: post #45

Earlier quoted context omitted.

Thanks! More details here: https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Message-Format... I hope my choices here work well on a wide variety of terminals.

I'd appreciate dropping red/green as bad/good colorscheme. red & green feed one of the most common visual impairments, and tend to work quite bad with terminal fg/bg colors throughout the spectrum except for its ends (black & white). Maybe you have some color profile descriptor somewhere that a user can change, but a quick search through info gcc (of my installed version) just shows the ability to turn it on & off (-…

Good point. I took a look, and it appears I hardcoded it, rather than going through our normal color management.

Sorry about that. I've filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114588 about this and I'll try to get it fixed before GCC 14 releases properly (i.e. for GCC 14.1)

Re: GCC 14 Boasts Nice ASCII Art for Visualizing Buffer Overflows

#53

Post by OneOfTheMicahs » Thu, Apr 04, 2024, 8:00 PM UTC

legobmw99 wrote: post #16

OneOfTheMicahs wrote: post #8

It looks very cool, but how do screen readers parse this? My guess is not well.

How well do screen readers parse other compiler errors? This isn’t me trying to be snarky, I actually have no idea! Reading a C++ template error is hard enough as a sighted person

For those curious, here's an example of emacspeak reading a fairly basic c error from the terminal: https://youtu.be/t3BgDa1p7Qc?feature=shared&t=270.

Re: GCC 14 Boasts Nice ASCII Art for Visualizing Buffer Overflows

#54

Post by ephaeton » Fri, Apr 05, 2024, 5:10 AM UTC

dmalcolm wrote: post #52

ephaeton wrote: post #49

Earlier quoted context omitted.

I'd appreciate dropping red/green as bad/good colorscheme. red & green feed one of the most common visual impairments, and tend to work quite bad with terminal fg/bg colors throughout the spectrum except for its ends (black & white). Maybe you have some color profile descriptor somewhere that a user can change, but a quick search through info gcc (of my installed version) just shows the ability to turn it on & off (-…

Good point. I took a look, and it appears I hardcoded it, rather than going through our normal color management. Sorry about that. I've filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114588 about this and I'll try to get it fixed before GCC 14 releases properly (i.e. for GCC 14.1)

awesome - thank you!