Live data from Hacker News

Xz: Can you spot the single character that disabled Linux landlock?

git.tukaani.org

101–110 of 322 posts

Re: Xz: Can you spot the single character that disabled Linux landlock?

#101

On an unrelated note, this malware team has assembled a great dataset for training AIs on identifying security problems. Every commit has some security problem, and the open source community will be going through and identifying them. (Thanks, maintainers, for the cleanup work; definitely not fun!)

One of the cooler uses of AI I've seen!

Re: Xz: Can you spot the single character that disabled Linux landlock?

#102
post #68

Earlier quoted context omitted.

Because a deliberate vulnerability is much easier to hide than actual malicious content. One could probably sneak a buffer overflow or use-after-free into a C project they maintain without being noticed. Actually shipping a trojan is much harder, as observed with the xz-to-sshd backdoor.

Ah, so the next stage would have been to add a "bug" in xz that would trigger during the supposedly sandboxed execution, when presented with certain input files. Clever.

Well, is also quite possible that adding such a bug was the previous stage. Or even just having found one that you didn't report/fix...

Re: Xz: Can you spot the single character that disabled Linux landlock?

#103
post #92

Earlier quoted context omitted.

This has plausible deniability on it. There's better ways to hide by swapping in Unicode lookalike characters. Some of them even pixel match depending on the font. Maybe I'm out of the loop but is intentionality settled here?

the period right there on the left edge? if I saw that in a patch I'd be through the roof, that looks completely intentional

I'd never suspect this to be intentional if I'd spot it in a patch, even given the consequences in this particular case. I have written and committed things into code instead of writing it into some other window several times. Without a linter I probably wouldn't spot an extra dot when reviewing my own change before sending it out.

Re: Xz: Can you spot the single character that disabled Linux landlock?

#105
post #46

Earlier quoted context omitted.

Ah yes but thanks to C being cursed due to includes and macros this is harder to do

Huh, the code with a dot is not legal C. It is CMake issue that the test breaks here.

That's kind of the point. It's feature detection code. If the code cleanly compiles, the feature is assumed supported, otherwise, it's assumed not present/functional. This pretty common with autotools. The gotcha here is this innocuous period is not supposed to be syntactically valid. It's meant to be subtle and always disable the feature.

Re: Xz: Can you spot the single character that disabled Linux landlock?

#106

Geez, his last commit is making security reports worse: https://git.tukaani.org/?p=xz.git;a=commitdiff;h=af071ef7702...

Why is that accepted? Serious question

Because nobody’s really paying attention.

“LGTM!”

Re: Xz: Can you spot the single character that disabled Linux landlock?

#107

Earlier quoted context omitted.

Why is that accepted? Serious question

Because nobody’s really paying attention. “LGTM!”

Generally yes, but ripping all conditions out of SECURITY.md should at least raise an eyebrow?

Re: Xz: Can you spot the single character that disabled Linux landlock?

#108
post #92

Earlier quoted context omitted.

This has plausible deniability on it. There's better ways to hide by swapping in Unicode lookalike characters. Some of them even pixel match depending on the font. Maybe I'm out of the loop but is intentionality settled here?

the period right there on the left edge? if I saw that in a patch I'd be through the roof, that looks completely intentional

Not me. Maybe someone is using an editor with a . key mapped to something. It's in a pretty convenient place.

:wq!

Re: Xz: Can you spot the single character that disabled Linux landlock?

#109

Earlier quoted context omitted.

Because nobody’s really paying attention. “LGTM!”

Generally yes, but ripping all conditions out of SECURITY.md should at least raise an eyebrow?

Nobody was watching. Plain and simple.

If you have commit access to it, and nobody is there to see, nothing stops you.

Re: Xz: Can you spot the single character that disabled Linux landlock?

#110
post #95

Earlier quoted context omitted.

This has plausible deniability on it. There's better ways to hide by swapping in Unicode lookalike characters. Some of them even pixel match depending on the font. Maybe I'm out of the loop but is intentionality settled here?

Unicode lookalikes would be detected by IDEs and other tools. There would be plausible deniability in a different situation, but this is the same author who implemented the backdoor and several similar changes that disable security features. I don't think the benefit of doubt is deserved here.

Ok there's a larger question here about the bazaar software development method.

How can we ensure say, that Microsoft doesn't pay someone to throw a wrench in libre office development or Adobe to sabotage Gimp?

There's lots of deception strategies for bad faith actors and given the paucity of people who actually do the work, it's really really hard to be picky.

Especially with the complexity of library dependencies. Defect-at-a-distance may actually be a common strategy and this is the first that was caught

Post reply on HN