Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Linus Torvalds won't do github pull requests

github.com

Post reply on HN
Print view View original

201–210 of 288 posts

Re: Linus Torvalds won't do github pull requests

#201

Post by sliverstorm »

ciupicri wrote: post #194
chj wrote: post #182

Earlier quoted context omitted.

Please name one project out performing Linux kernel in terms of your definition of code quality. I'd like to have a surprise.

I can't speak for himself, but BSDs, especially NetBSD and OpenBSD are known for their code quality. Quoting from "What is NetBSD?"[1]: "The basic features of NetBSD are: Code quality and correctness ...". [1] http://www.netbsd.org/docs/guide/en/chap-intro.html [2] http://corte.si/posts/code/reading-code.html

While you are only doing as chj asks, I would point out that NetBSD and OpenBSD have the advantage of being exceedingly compact, simple, have fewer features, fewer contributors, and generally travel at a slower development pace.

Re: Linus Torvalds won't do github pull requests

#202

Post by rumcajz »

Kiro wrote: post #27
rumcajz wrote: post #2

That's pretty relevant comment. GitHub pull request system is great if you want to attract a bunch of script kiddies to participate on your project. For serious work, not so much.

Why would pull requests attract script kiddies?

Because they are insanely easy to do, at the expense of sane formal process.

Re: Linus Torvalds won't do github pull requests

#203

Post by trafficlight »

ash wrote: post #197
jasonwatkinspdx wrote: post #189

Earlier quoted context omitted.

I think people are arguing for two reasons: 1.) Linus is being a bully. There's a difference between speaking your mind openly and using rhetorical force to invalidate contrary views. 2.) The kernel requirements can be whatever those who control the kernel demand. That's just common sense. Making the leap to declaring that only one text wrapping approach is objectively correct is delusional. If Linus simply said "The…

I don't think his goal is to have no arguments. His goal seems to be "fix this issue, god damn it!" And amusing rant can help bring attention to the issue (note tomayko comment in the original thread). I don't know about you, but the rant is entertaining to me.

My take from that message is he doesn't care if they fix it or not, but rather he won't be doing pull requests in it's current state.

Re: Linus Torvalds won't do github pull requests

#204

Post by jonhendry »

chj wrote: post #162
krschultz wrote: post #114

Earlier quoted context omitted.

I don't see where he is being unreasonable. He made git with his specific method of managing the Linux source repository in mind. Now someone wants him to ignore part of his tool for their connivence and he said no. He's not saying "we should all boycott GitHub because of it". He's not saying "they're idiots for doing this". He's saying 'The Linux project works one way, GitHub doesn't support that way, so we're not u…

> He's saying 'The Linux project works one way, GitHub doesn't support that way, so we're not using it, and they' won't change it'. That's it. That is the spirit! I remembered he once said talking angrily is to scare idiots off. What a man.

It probably also helps cut down on people trying to whine and wheedle their way to his acquiescence.

Think of a college student, relentlessly begging the professor for an A on a paper that just barely deserved a B-.

Re: Linus Torvalds won't do github pull requests

#205

Post by nwmcsween »

chj wrote: post #182
nwmcsween wrote: post #106

Earlier quoted context omitted.

Linux and code quality? I think you may be confused.

Please name one project out performing Linux kernel in terms of your definition of code quality. I'd like to have a surprise.

Define code quality: braindead GNU extensions such as nested functions - Linux uses that, How about the separation of DM and MD due to ego's, how every driver without a lib (such as libata) warranting a few exceptions has to rewrite boilerplate for basic things - frame buffer drivers are a good example. How about the syscall bugs - look into glibc if you feel like gouging your eyes out or jemalloc for more tame code. Linux itself is more an ecosystem of code and not a single project some parts are good while others are very very bad.

Re: Linus Torvalds won't do github pull requests

#206

Post by drivebyacct2 »

scorpion032 wrote: post #200
drivebyacct2 wrote: post #147

Earlier quoted context omitted.

Because being strong minded about git commit message styles is the same thing as "code quality"?

because both are the consequence of a same inner quality. Caring .

I know what you mean, but I don't think the logic follows properly. I think that someone who cares is likely to write better code than if they didn't, but I can assure from my limited experience working with others, caring and passion doesn't make someone a good programmer.

Re: Linus Torvalds won't do github pull requests

#208

Post by saurik »

laughinghan wrote: post #185
tytso wrote: post #159

I don't understand why people are upset with Linus's writing style. I considered what he wrote to be quite polite. He was merely stating his standards in terms of what he would and wouldn't accept (and github pull requests are on the "won't accept" list). He even explained why he wouldn't accept it. Furthermore, the patch was deficient in other ways. (a) it was missing the Signed-off-by: header, and (b) it should hav…

I think it was comments like "The fact that I have higher standards then makes people like you make snarky comments, thinking that you are cool. You're a moron." that people thought impolite. The comment he responded to appears to have been deleted, however, so I can make no judgement about how appropriate that was. I'd like to think it was completely appropriate -- I do agree with you overall that his other comments…

I don't remember the exact wording of the comment that was deleted, but I did see it and I remember it making me feel very angry, despite that I wasn't even involved in the discussion. My personal belief is that Linus' response was quite classy in comparison, especially given that others in the conversation weren't stepping up to take issue with the comment.

Re: Linus Torvalds won't do github pull requests

#209

Post by ocelotpotpie »

peterwwillis wrote: post #207

If somebody invents a car and gives it to Torvalds, he'll call the designers total morons if the blinker isn't at the height that he likes.

This seems a bit misplaced. More like if Torvalds invents a motor and then someone puts it in a car, he might complain if the motor doesn't run the way he'd like. Which isn't entirely unreasonable.
Post reply on HN