Live data from Hacker News

Linus Torvalds won't do github pull requests

github.com

111–120 of 288 posts

Re: Linus Torvalds won't do github pull requests

#111
post #79

Earlier quoted context omitted.

git request-pull If you'd like to see an example, this will generate the text of a request sending the top few commits in your repository (assuming the origin / master convention) git request-pull master^^^^^ $(git config remote.origin.url)

A tip - you can use master~5 instead of master^^^^^.

Thanks! I expected someone might save me the time of looking that up.

Re: Linus Torvalds won't do github pull requests

#113
post #55

Fun Fact: If you tack '.patch' onto the end of a Pull Request you get a 'git am' compatible patch file complete with the email address that Linus complains is missing ;) https://github.com/torvalds/linux/pull/17.patch EDIT: I should note this works on any commit as well. Take this commit from Casbah (the Scala MongoDB driver I work on) - https://github.com/mongodb/casbah/commit/990a36fbde69db26689... - removing .patc…

[deleted]

Re: Linus Torvalds won't do github pull requests

#114

I don't mean to be overly critical, but is it just me or are the 'godfathers' of computer science starting to sound like cranky old men? I mean....ok....this pull request being inferior to the way HE (the creator of Git) imagined it (or implemented it) is a bit petty imho. What's with the complaining? I am sure this is not the first time I have heard him complaining about something on Github or some other 'new techno…

I don't see where he is being unreasonable. He made git with his specific method of managing the Linux source repository in mind. Now someone wants him to ignore part of his tool for their connivence and he said no.

He's not saying "we should all boycott GitHub because of it". He's not saying "they're idiots for doing this".

He's saying 'The Linux project works one way, GitHub doesn't support that way, so we're not using it, and they' won't change it'. That's it.

Re: Linus Torvalds won't do github pull requests

#115
post #113
post #55

Fun Fact: If you tack '.patch' onto the end of a Pull Request you get a 'git am' compatible patch file complete with the email address that Linus complains is missing ;) https://github.com/torvalds/linux/pull/17.patch EDIT: I should note this works on any commit as well. Take this commit from Casbah (the Scala MongoDB driver I work on) - https://github.com/mongodb/casbah/commit/990a36fbde69db26689... - removing .patc…

[deleted]

How is your email "supposedly private" if it's in a public git repository?

Re: Linus Torvalds won't do github pull requests

#116

Earlier quoted context omitted.

Funnily enough...DHH's talk is EXACTLY the first thing that came to mind when I saw Torvald's comment. Who cares if Torvalds has 'more' technical chops than DHH...DHH might be more abrasive, but it is a good abrasive. He is always pushing the community forward and encouraging Rails developers to be a little better. He is not afraid to embrace new technologies and give credit where its due. Can't tell when last I have…

You can't see how the head Linux kernel dev has been pushing the community foward? Okay then.

Heh.....you misunderstood me.

I have never once bashed his contributions to the community and OSS. Just like I would never do the same for the creators of Java, C, PHP, all of which I don't use and have no interest in. But there is significant value in all of them and we are all better off for their existence.

My point was, more often than not....you hear the creators of these 'foundational' contributions complaining about new things (either new approaches which were different than theirs, or they shit on new languages because those languages don't have some purist function that theirs does or doesn't achieve the same low-level execution speed that theirs does).

DHH can be a dick, but I have never seen him shit on someone for trying something new (even within the Ruby & Rails core). That being said, I am not saying he doesn't disagree with the approach that people take....but there is a difference between shitting on someone/something and disagreeing with it.

What Linus did here was shit all over Github's implementation of the pull request - because it is different than his implementation would have been.

Re: Linus Torvalds won't do github pull requests

#117
post #113
post #55

Fun Fact: If you tack '.patch' onto the end of a Pull Request you get a 'git am' compatible patch file complete with the email address that Linus complains is missing ;) https://github.com/torvalds/linux/pull/17.patch EDIT: I should note this works on any commit as well. Take this commit from Casbah (the Scala MongoDB driver I work on) - https://github.com/mongodb/casbah/commit/990a36fbde69db26689... - removing .patc…

[deleted]

[deleted]

Re: Linus Torvalds won't do github pull requests

#119
post #113
post #55

Fun Fact: If you tack '.patch' onto the end of a Pull Request you get a 'git am' compatible patch file complete with the email address that Linus complains is missing ;) https://github.com/torvalds/linux/pull/17.patch EDIT: I should note this works on any commit as well. Take this commit from Casbah (the Scala MongoDB driver I work on) - https://github.com/mongodb/casbah/commit/990a36fbde69db26689... - removing .patc…

[deleted]

It isn't private. Pull the repo and use git-log to see all the email addresses of all the commits.

Re: Linus Torvalds won't do github pull requests

#120

Earlier quoted context omitted.

Linus is kind of infamous for his rants and have been for years (especially on the mailing lists.. I've seen him tear into people for willful ignorance on the kernel dev lists more than once). I've never really seen them as cranky because they're spot on. Cranky old men usually don't have anything other than opinion behind their rantings.. Linus can at least defend his position. Given his contributions to the world o…

Well...this debate always seems to come down to...do we let geniuses just do whatever the hell they want. The answer is...I am not sure. Either way, there are many decisions that people make that comes down to style preference and sure the 'purists' might think it is a watering down of programming....but it makes it more appealing to new developers. I can see Torvalds ranting on Ruby as not a 'real' language....I don…

In this particular case, nobody's coddling him because he's a genius, but because it's his repository that he's talking about whether or not to accept pull requests for.

Simply put, he has a rigid standard for pull requests, and GitHub isn't capable of adhering to it, so he can't (without making an exception) accept pull requests using the tool.

The rest of his ranting is mostly subjective, but I do find it amusing that pull requests in the number 1 git hosting service don't meet the creator's muster, and I'd love to know the reasoning behind their implementation.

For what it's worth, I didn't know of the in-built git pull request and I'm an avid Github user (though not submitting Linux kernel patches,) so in the spirit of optimism, airing this rant was informative to at least me, and probably many others.

Post reply on HN