[dead]
Ask HN: Does "trust" eliminate the need for code reviews?
71–77 of 77 posts
Re: Ask HN: Does "trust" eliminate the need for code reviews?
#72[dead]
Re: Ask HN: Does "trust" eliminate the need for code reviews?
#73[dead]
Re: Ask HN: Does "trust" eliminate the need for code reviews?
#74This is just ridiculous. People make mistakes. People should also be relatively familiar with what goes on in the codebase.
Re: Ask HN: Does "trust" eliminate the need for code reviews?
#75Hell No. Code reviews have nothing to do with “trust”. It is another pair of eyes proof reading your code and providing at least a sanity check of the logic. Think of this way. When you were in college you wouldn’t turn in an important paper without anyone proofreading it right? Well the code you write deserves at least as much rigor as your sociology term paper did.
Amen
Re: Ask HN: Does "trust" eliminate the need for code reviews?
#76Oof. Difficult one. I've dealt with multiple people and there are some I would blindly trust because I know they would do the right thing. On the other hand I've worked with people who need more reminders (eventually we had to discontinue our relationship) to do the right thing: Does the PR make sense? Did you format the code? Did the tests pass? Did you fix the tests? Or did you just comment them out? And for the pe…
Did you format the code? Is this really a thing in 2023?
Re: Ask HN: Does "trust" eliminate the need for code reviews?
#77Oof. Difficult one. I've dealt with multiple people and there are some I would blindly trust because I know they would do the right thing. On the other hand I've worked with people who need more reminders (eventually we had to discontinue our relationship) to do the right thing: Does the PR make sense? Did you format the code? Did the tests pass? Did you fix the tests? Or did you just comment them out? And for the pe…
Did you format the code? Is this really a thing in 2023?
In the case you're serious: yes, we've had issues with developers changing code inside of GitHub and then committing, which obviously increases nose in future diffs that are done with a formatter installed. We fixed this by enforcing a formatter at the CI level.
In the case you're wondering if formatting code is important: it's a hill I'm willing to die on. It costs nothing but it removes an insane amount of discussion and noise when doing reviews.