11–20 of 77 posts
But also the point of code review is not just to catch mistakes, suggest improvements, etc, but as a way to learn and keep up-to-date with the code base, and also to pick up tips or whatever from other developers.
And I guess a meta-point is it's one of a number of practices that makes the team a team.
It’s about risk management, communication and teamwork.
Development at scale is a team sport. There’s a difference and it’s simple starting with…
- Does my team understand this change?
- Is there anything I missed that would have a negative impact on others?
I work with people I do "trust" and my code-review is usually "LGTM" -- often without even looking. Most code doesn't go right to production and can be fixed if there are bugs (which I'm unlikely to find by looking at it, anyway.)
The things I look at are things that are hard to change in the future: big architectural decisions, schema (db and data format) changes and things like that.
More junior and newer people, I tend to look more closely and give more advice.
Personally, I get annoyed when people feel they need to critique something to make it clear they reviewed the code. In most cases, the feedback I get from reviewers is not consequential -- and just slows things down. But I have certainly had cases where the reviewer made great points and I changed the code to fit.
No. I trust myself. I still want someone to review my work. If nothing else than to essentially catch typos. You can’t proofread your own output.
It’s about risk management, communication and teamwork. Development at scale is a team sport.
There’s a difference and it’s simple starting with…
- Does my team understand this change?
- Is there anything I missed that would have a negative impact on others?
For example, if my team was very junior, I'd be less inclined to merge first, but if it was very senior, I'd be more inclined. But even then, it depends on other factors.
If you think you can deal with the quality hit then yeah I guess just go crazy, spurt out another buggy pile, just don't bother me about it.