Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Bluesky migrates to single-tenant SQLite

github.com

Post reply on HN
Print view View original

51–60 of 247 posts

Re: Bluesky migrates to single-tenant SQLite

#51

Post by lolinder »

88913527 wrote: post #48
lolinder wrote: post #41

Earlier quoted context omitted.

I prefer to have clear commits that tell a tidy story. For example: * Refactor function `foo` to accept a second parameter * Add function `bar` * Use `bar` and `foo` in component `Baz` to implement feature #X If you give me a commit history like this, I can easily validate that each step in your claimed process does what you describe. If you instead give me a messy history and ask me to read the diff, you might know…

This is reasonable, but the problem I encounter is how stifling it seems to ask others to structure their work so specifically. By way of comparison, getting compliance on conventional commit messages is a challenge, and that's an appreciably smaller ask than this.

Oh, for sure. This is how I structure my own PRs, but I've certainly never bothered to ask a coworker to do so, I just appreciate it when I see it.

That said, OP is in an environment where it sounds like this kind of structure is already the cultural norm.

Re: Bluesky migrates to single-tenant SQLite

#53

Post by nemo44x »

focom wrote: post #3

I am curious, does the HN folks know if bluesky is more active than nostr or the mastodon network?

They’re all just arbitrary ghettos that aren’t dissimilar to each other. None of them matter in terms of influence but are like nice Reddit boards for certain interests.

Re: Bluesky migrates to single-tenant SQLite

#54

Post by recursive »

readline_prompt wrote: post #34
lrx wrote: post #29

Earlier quoted context omitted.

I prefer to read the unified diff and commits don't matter as much.

don't know why, but recent teams around me have always made strict rules about number of commits in PRs. I just wanted to tell them the same thing you said: "Why don't you just look at the diffs?" curious for other opinions. (sorry not really about this particular topic)

Easy workaround. Start with feature branch f.

1. Branch f-prime from master. 2. Squash merge f to f-prime. 3. Pull request f-prime to master. 4. Profit.

Re: Bluesky migrates to single-tenant SQLite

#55

Post by defatigable »

JosephK wrote: post #40
nvy wrote: post #13

Earlier quoted context omitted.

Yes. I have invite codes if you would like one. Email in my profile. Edit: they're all gone!

Is your offer invite code available to other randoms like myself? I tried to register on bsky months ago and still haven't been approved.

I have some extra if you'd like one. Let me know how to get it to you and I will.

Re: Bluesky migrates to single-tenant SQLite

#56

Post by throwaway892238 »

lrx wrote: post #29
scorpion_farmer wrote: post #27

That looks like the PR from hell - 190 files changed, 143 commits? Mostly with names like "tidy" and "wip" Props to whoever actually reviewed that, you are a warrior

I prefer to read the unified diff and commits don't matter as much.

I don't think any method is gonna make it easy to grok 3,336 added lines and 5,421 removed

Re: Bluesky migrates to single-tenant SQLite

#57

Post by azemetre »

defatigable wrote: post #55
JosephK wrote: post #40

Earlier quoted context omitted.

Is your offer invite code available to other randoms like myself? I tried to register on bsky months ago and still haven't been approved.

I have some extra if you'd like one. Let me know how to get it to you and I will.

If you're offering I'd love one. My email is my username on hackernews at gmail.com

Re: Bluesky migrates to single-tenant SQLite

#58

Post by rgoulter »

4death4 wrote: post #30
scorpion_farmer wrote: post #27

That looks like the PR from hell - 190 files changed, 143 commits? Mostly with names like "tidy" and "wip" Props to whoever actually reviewed that, you are a warrior

What if it was 190 files changed in 1 commit, would that make a difference?

It might.

With commits like "typo", you might as well squash these into the commit which introduced the typo in the changeset.

If there are changes across many files, and the changes were made automatically with some search-and-replace (or some refactoring tool).. by having a commit that's only that automatic change, it's easy to look at that commit and tell what the changes were. -- Presumably, non-automatic changes are going to be smaller.

I guess roughly, if it makes sense to apply a changeset that changes 5 things, you'd want 5 commits. Having commits like "typo" means there are more commits; but squashing those 5 things together makes it harder to discern the granular change.

Re: Bluesky migrates to single-tenant SQLite

#59

Post by nvy »

JosephK wrote: post #40
nvy wrote: post #13

Earlier quoted context omitted.

Yes. I have invite codes if you would like one. Email in my profile. Edit: they're all gone!

Is your offer invite code available to other randoms like myself? I tried to register on bsky months ago and still haven't been approved.

I'm happy to give them to any HN user but I'm afraid I have only three left and there are three emails in my inbox asking for invites, so if one is you then congratulations! Otherwise, sorry.
Post reply on HN