Better HTTP server routing in Go 1.22

Post by shortrounddev2 » Mon, Oct 16, 2023, 4:30 PM UTC

neonsunset wrote: post #106

shortrounddev2 wrote: post #63

How did this kind of syntax become so popular? I think express is the first to do the scheme of: app.handleGet("/route/goes/here", (req, res) => { }); Which seems like it's useful for making really quick and dirty micro-services (nano-services, even), but I still vastly prefer the more declarative and modular schemes of bootstrap or asp.net: // Middleware automatically routes "/Foo" to FooController [Controller] publ…

Controller style declaration is often an overkill, it's also not exactly friendly to AOT. I personally prefer using MinApi style of declaration (first example). It can do request validation, model binding and inject services too: app.MapGet("/", async ( [FromBody] User user, [FromServices] MyService service) => { await service.Handle(user); return Results.Ok(); });

Post by shortrounddev2 » Mon, Oct 16, 2023, 4:32 PM UTC

badrequest wrote: post #104

shortrounddev2 wrote: post #96

Earlier quoted context omitted.

> The second example has poor readability Only if you don't know C# or asp.net (or bootstrap). In which case: why would you be working for an organization which does? > And that's even before we get to the issue that this approach has fallen out of favor exactly because it result in code that can be a pain in the neck to figure out. This kind of structured approach has fallen out of favor because it's become more pop…

> Only if you don't know C# or asp.net (or bootstrap). In which case: why would you be working for an organization which does? You've never taken a job working in a language you don't know yet? Anecdotally this is a common thing. In fact, my most recent job hired me to write C# with nothing but prior Go/Python experience. > This kind of structured approach has fallen out of favor because it's become more popular to h…

Post by thiht » Mon, Oct 16, 2023, 4:33 PM UTC

imetatroll wrote: post #36

Man I really really dislike this proposal. Putting the http request method into the URI... an just sometimes... oh and maybe do "POST,PUT,PATCH /something". Just no thank you. Make a dedicated method that accepts http request method names if you must do something.

Post by shortrounddev2 » Mon, Oct 16, 2023, 4:35 PM UTC

neonsunset wrote: post #110

shortrounddev2 wrote: post #86

Earlier quoted context omitted.

The 2nd example: 1. Uses declarative routing, which looks better and makes more sense than running a function to handle routing (e.g, you read it as "There is a handler named GetFoo living within the Foo controller that exists at the base route"). Declaration is more important to the end user than implementation when creating an interface. It also allows you to export these classes to a different Main method which ca…

This is straight up wrong. Documentation can be generated from either pattern. It can also do authorization if you wish so (middlewares, attributes, you can do it however you want). We get it, you like the controller pattern, but please do not post incorrect information to prove the point.

Post by barsonme » Mon, Oct 16, 2023, 4:42 PM UTC

Macha wrote: post #102

avianlyric wrote: post #8

Earlier quoted context omitted.

Isn’t that just a consequence of Go’s backwards compatibility guarantee? Adding new arguments to the Mux interface would break existing code, given the method signature can’t be changed, these magic strings seem like a reasonable compromise. It not like HTTP verbs are going to change anytime soon, and it’s trivial to validate them during register, or via static analysis. So I’m not sure what value the use of constant…

Surely the changes to panic on conflicting routes being discussed upstream already prove they're willing to flex on that guarantee?