Live data from Hacker News

Show HN: Graphite – Stacked Diffs on GitHub

news.ycombinator.com

31–40 of 65 posts

Re: Show HN: Graphite – Stacked Diffs on GitHub

#31
post #2

Excited to see the progress here on the public launch! Stacking was a meaningful time-saving as a FAANG sw eng. Excited to see stacking grow within the great tech community

Thanks for the support @zurawiki

Agreed! We think this is a huge performance boost and why we think any engineer should benefit from stacking!

Re: Show HN: Graphite – Stacked Diffs on GitHub

#32
post #30

I don't understand how this is a difference between stacked diffs and feature branches. Github allows you to use feature branches. I can see there might be some convenience with tooling

https://stacking.dev/ has a good summary of this!

tl;dr the difference is a stack is merged partially as it's built out (that reduces merge conflicts, allows you to revert individual parts as found) and a feature branch is long-lived. Hope that helps :)

Re: Show HN: Graphite – Stacked Diffs on GitHub

#34
post #27

I've been using this for a few months now, and it's been an absolute joy to use. One thing that's been a bit annoying: my org enforces signed commits, and when you merge a stack, they sometimes rebase commits internally and lose the code signing, so you end up with an error to merge the rest of the stack. Aside from that, working with stacks has been great!

Hey @njaremko, Thank you for using Graphite and your support. This is something we're aware of and current thinking around. Question, if we were to support this by signing commits: Would you want the commit to be signed by the Graphite GitHub App? Or would you prefer for it to be signed by Graphite on behalf of you? Or some other option that we haven't considered? -Xiulung (UX @ Graphite)

I think letting me give you a gpg private key and you sign commits with that would be ideal. I'm not sure how the app signing commits would work, since it needs to be signed by a member of our org I believe?

Re: Show HN: Graphite – Stacked Diffs on GitHub

#37
post #27

Earlier quoted context omitted.

Hey @njaremko, Thank you for using Graphite and your support. This is something we're aware of and current thinking around. Question, if we were to support this by signing commits: Would you want the commit to be signed by the Graphite GitHub App? Or would you prefer for it to be signed by Graphite on behalf of you? Or some other option that we haven't considered? -Xiulung (UX @ Graphite)

I think letting me give you a gpg private key and you sign commits with that would be ideal. I'm not sure how the app signing commits would work, since it needs to be signed by a member of our org I believe?

then why not let them generate the key itself?

Re: Show HN: Graphite – Stacked Diffs on GitHub

#38
post #30

I don't understand how this is a difference between stacked diffs and feature branches. Github allows you to use feature branches. I can see there might be some convenience with tooling

It's a fair question! There are a lot of perks to splitting up your change into multiple PRs rather than one feature branch. You can parallelize getting reviewed while writing more code. If CI fails, it fails on a more narrowly scoped change and is easier to debug. If something about one of your changes is unmergable, you may still be able to merge in half of your stack, rather than your change being all-or-nothing.

A lot of the benefits remind me of other dag-based workflows, like CI, data pipelines, or build systems. Does that make sense?

Post reply on HN