I've used Pixel phones since the first Pixel came out and I've been in love ever since. I'm also on Google Fi so that might skew things a little bit because everything is just so seamless and it works so perfectly. I love the camera on the Pixel phones and I love the fact that I can get the latest beta updates for Android and that my Android experience is basically as stock as can be. I don't root my phone because it wouldn't give me anything that I don't already have. I use all of the Google features quite extensively so I don't need to like remove anything from the phone.
There really isn't anything I look for in a phone. My current upgrade schedule is... Well, I had the Pixel 1 and then I went to a pixel 2 and then when that stopped getting software updates entirely I bought a pixel 5 and then I bought the Pixel fold and I'm going to keep this until it also stops receiving any updates. Then I'll buy whatever the just launched pixel is at that point in time.