Epic Pull Requests

#1

Post by bluesmoon » Wed, Mar 21, 2012, 7:53 PM UTC

Epic Pull Requests
epicpullrequests.tumblr.com

Re: Epic Pull Requests

#2

Post by wickedchicken » Wed, Mar 21, 2012, 8:18 PM UTC

You ought to add this one: https://github.com/charliesome/Fructose/pull/9

Make sure to look at https://github.com/charliesome/Fructose/pull/9/files for full effect.

Re: Epic Pull Requests

#3

Post by dchest » Wed, Mar 21, 2012, 8:21 PM UTC

wickedchicken wrote: post #2

You ought to add this one: https://github.com/charliesome/Fructose/pull/9 Make sure to look at https://github.com/charliesome/Fructose/pull/9/files for full effect.

And the humor here is that some guy bullies another guy?

Re: Epic Pull Requests

#4

Post by ryanbraganza » Wed, Mar 21, 2012, 8:31 PM UTC

wickedchicken wrote: post #2

You ought to add this one: https://github.com/charliesome/Fructose/pull/9 Make sure to look at https://github.com/charliesome/Fructose/pull/9/files for full effect.

I prefer this one https://github.com/saberma/shopqi/pull/409

Re: Epic Pull Requests

#5

Post by adambard » Wed, Mar 21, 2012, 8:53 PM UTC

dchest wrote: post #3

wickedchicken wrote: post #2

You ought to add this one: https://github.com/charliesome/Fructose/pull/9 Make sure to look at https://github.com/charliesome/Fructose/pull/9/files for full effect.

And the humor here is that some guy bullies another guy?

It's a bit mean, but a Ruby-to-PHP compiler implemented in C#? I feel like 3 is a crowd here.

Re: Epic Pull Requests

#6

Post by akkartik » Wed, Mar 21, 2012, 9:03 PM UTC

My all-time favorite commits (not pull requests) are the first few at http://github.com/diiq/Tainted-Oyster/commits/master. Navigate through to page 1, and read in chronological order.

Eventually the compiler design problem got so hard it took up all the author's neurons :/

Re: Epic Pull Requests

#7

Post by johncoltrane » Wed, Mar 21, 2012, 9:32 PM UTC

akkartik wrote: post #6

My all-time favorite commits (not pull requests) are the first few at http://github.com/diiq/Tainted-Oyster/commits/master . Navigate through to page 1, and read in chronological order. Eventually the compiler design problem got so hard it took up all the author's neurons :/

This is beautiful. Thank you.

Re: Epic Pull Requests

#8

Post by marshray » Wed, Mar 21, 2012, 9:35 PM UTC

Very cool.

I hope this doesn't catch on and raise the bar for ordinary patch submissions.

Re: Epic Pull Requests

#9

Post by Splines » Wed, Mar 21, 2012, 9:41 PM UTC

As a parent that has read "Cat in the Hat" countless times to two children, that first entry on the page is a poetic monstrosity. Cute, but terrible.

Re: Epic Pull Requests

#10

Post by eferraiuolo » Wed, Mar 21, 2012, 11:23 PM UTC

Feel free to submit Pull Requests here: http://epicpullrequests.tumblr.com/submit and I can add them (the epic ones of course).