Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Git-appraise – Distributed Code Review for Git

github.com

Post reply on HN
Print view View original

31–40 of 173 posts

Re: Git-appraise – Distributed Code Review for Git

#31

Post by pgeorgi »

rcme wrote: post #8
matt-robertson wrote: post #4

Earlier quoted context omitted.

I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. https://github.com/google/git-appraise/blob/master/docs/tuto... A trivial git-hook could be setup for automating email notifications: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks EDIT: add link to git-hooks docs.

> I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. How do they push without a server to host the repository?

They push to their own server and ask you to pull from there. See https://lkml.org/lkml/2023/6/25/128 for an example.

Re: Git-appraise – Distributed Code Review for Git

#33

Post by alkonaut »

ortichic wrote: post #30
KolmogorovComp wrote: post #27

Looks neat in theory, but in practice how is the experience? Can anyone who used it give some feedback?

I mean... Just look at how to comment some line: `git appraise comment -f README.md -l 2 -m "Ah, so that's what this is" 1e6eb14c8014`

That is hopefully managed by a plugin to vscode or a web app. Git feels like the substrate, appraise the middle layer, and for mot use cases an UI would be added on top.

Unlike regular git where command line is surprisingly useful despite being an awful mess (It's just hard to make better tools for many git tasks), I don't think command line code reviews would be the primary user interface.

Re: Git-appraise – Distributed Code Review for Git

#34

Post by raffraffraff »

Would it be possible to build a gitlab-like ui that is completely decentralized? Instead of depending on (or paying $$$ for) some web UI that wraps standard git functionality, could we run something completely locally that keeps repos/branches in sync and provides the basic merge/comment/review functionally that most people use? In other words, let me host the most basic git server in the world and put the complexity at the client?

Edit: I wondered about using a separate Blockchain to maintain consensus on the "central" representation of the repo that we get from a "git server". This answer is useful, I think I'll digest it and ponder some more...

https://stackoverflow.com/a/59509859

Edit2: I also wondered if anyone implemented git server as an extremely thin layer on top of s3, but the only project I found was abandoned many years ago.

Re: Git-appraise – Distributed Code Review for Git

#35

Post by hnben »

ortichic wrote: post #30
KolmogorovComp wrote: post #27

Looks neat in theory, but in practice how is the experience? Can anyone who used it give some feedback?

I mean... Just look at how to comment some line: `git appraise comment -f README.md -l 2 -m "Ah, so that's what this is" 1e6eb14c8014`

there is a web interface [1] and also an eclipse plugin [2]. It would be nice if there was an intellijplugin as well.

[1] https://github.com/google/git-appraise-web [2] https://github.com/google/git-appraise-eclipse

Re: Git-appraise – Distributed Code Review for Git

#36

Post by infogulch »

Arbortheus wrote: post #28
bhawks wrote: post #24

Storing code review (and ci results, and analyzer runs) in git is a wonderful idea. All these workflows are a derivation of the source in the repository and keeping them close together has a great aesthetic. It also enables the 'single pane of glass' to observe the a pull request from.

I assume it would also have the advantage of not tying the code reviews and PRs to a proprietary git provider. Say I move from GitHub to GitLab, I assume I lose all the PR descriptions and comments people have made over the years and only keep the commit messages. It would be nice to have a provider-agnostic representation of this data.

I seem to recall the gitea project working on something like git-tracked metadata (PRs, issues, etc), at least the idea has been floating around for a while. One problem with this idea that I haven't seen a good solution for is serializing issue numbers across distributed forks. Maybe we would give up nice sequential numbers and settle for hashed issue refs.

Re: Git-appraise – Distributed Code Review for Git

#37

Post by glodalitazic »

For years i am thinking already about building an ide plugin for this. There is an eclipse implementation, but I'd love to have intellij. Leaving the ide for code reviews is a no-go. I started looking into adapting the intelij github plugin for this, or the gerrit plugin but didn't succeed yet. If someone is interested in collaborating we can open an org and a repo.

a vscode plugin and maybe integration into gitea would be nice as well.

Edit: there is https://github.com/thigg/appraise-intellij but this is a mere POC

Re: Git-appraise – Distributed Code Review for Git

#40

Post by glodalitazic »

glodalitazic wrote: post #37

For years i am thinking already about building an ide plugin for this. There is an eclipse implementation, but I'd love to have intellij. Leaving the ide for code reviews is a no-go. I started looking into adapting the intelij github plugin for this, or the gerrit plugin but didn't succeed yet. If someone is interested in collaborating we can open an org and a repo. a vscode plugin and maybe integration into gitea wo…

I could also imagine to store metadata from the ide next to the pr. The ide knows a lot of things about the change when doing refactorings that do not trivially reflect in the diff. E.g. Extractions and renamings... if I could do a review and the system would tell what happened instead of what changed in some cases, that would be so useful. never ever reviewing 1000 lines of class renamings anymore...
Post reply on HN