Weekend project: A place to post crappy code. HatePaste • Hacker News Board

Re: Weekend project: A place to post crappy code. HatePaste

#11

Post by LuxuryMode » Mon, Mar 05, 2012, 8:17 PM UTC

franze wrote: post #9

please hate it http://hatepaste.com/paste/155205ac

haha awesome. hated it

Re: Weekend project: A place to post crappy code. HatePaste

#12

Post by koenigdavidmj » Mon, Mar 05, 2012, 8:30 PM UTC

biot wrote: post #10

It's interesting that this is one of the most hated ( http://hatepaste.com/paste/f5da3584 ): if (someBoolean == true) { doSomething(); } I got into the habit of doing this since it's immediately obvious that the value you're comparing is expected to be a boolean and not something like an integer, which could cause subtle bugs later on if what you thought was a boolean gets negated. More commonly, it's of the form: if…

In Java, it's a compile error to pass something not of type `bool' into that expression, so things like

  if (someBoolean)

Are unambiguous.

Re: Weekend project: A place to post crappy code. HatePaste

#13

Post by DrCatbox » Mon, Mar 05, 2012, 8:30 PM UTC

biot wrote: post #10

It's interesting that this is one of the most hated ( http://hatepaste.com/paste/f5da3584 ): if (someBoolean == true) { doSomething(); } I got into the habit of doing this since it's immediately obvious that the value you're comparing is expected to be a boolean and not something like an integer, which could cause subtle bugs later on if what you thought was a boolean gets negated. More commonly, it's of the form: if…

Its far easier to read if (!someBoolean) than if (someBoolean == false)

Ofcourse, your example probably applies to JavaScript since anything and everything can be a boolean, or not depending on the phase of the moon. In Java at least if not someBoolean is nice to read, and if (isGood) is nicer than if (isGood == true).

Re: Weekend project: A place to post crappy code. HatePaste

#14

Post by dan-g » Mon, Mar 05, 2012, 8:32 PM UTC

This is awesome, but it'd be really nice if you could vote on the overview pages (Most Hated, Most Alright, Newest, etc) for the shorter examples rather than having to click on through to its own unique page.

Re: Weekend project: A place to post crappy code. HatePaste

#15

Post by biot » Mon, Mar 05, 2012, 8:38 PM UTC

koenigdavidmj wrote: post #12

biot wrote: post #10

It's interesting that this is one of the most hated ( http://hatepaste.com/paste/f5da3584 ): if (someBoolean == true) { doSomething(); } I got into the habit of doing this since it's immediately obvious that the value you're comparing is expected to be a boolean and not something like an integer, which could cause subtle bugs later on if what you thought was a boolean gets negated. More commonly, it's of the form: if…

In Java, it's a compile error to pass something not of type `bool' into that expression, so things like if (someBoolean) Are unambiguous.

True. I suppose this is more of a holdover from my C programming days.

Re: Weekend project: A place to post crappy code. HatePaste

#16

Post by polyfractal » Mon, Mar 05, 2012, 8:49 PM UTC

DrCatbox wrote: post #13

biot wrote: post #10

It's interesting that this is one of the most hated ( http://hatepaste.com/paste/f5da3584 ): if (someBoolean == true) { doSomething(); } I got into the habit of doing this since it's immediately obvious that the value you're comparing is expected to be a boolean and not something like an integer, which could cause subtle bugs later on if what you thought was a boolean gets negated. More commonly, it's of the form: if…

Its far easier to read if (!someBoolean) than if (someBoolean == false) Ofcourse, your example probably applies to JavaScript since anything and everything can be a boolean, or not depending on the phase of the moon. In Java at least if not someBoolean is nice to read, and if (isGood) is nicer than if (isGood == true).

I think this is a pretty subjective topic - you can't say that one way is easier to read than any other way (for anyone except yourself).

Some people prefer verbosity over brevity, just like some people prefer K&R braces to Allman, or CamelCase to underscoring.

Re: Weekend project: A place to post crappy code. HatePaste

#17

Post by tylerlh » Mon, Mar 05, 2012, 9:02 PM UTC

platzhirsch wrote: post #2

I love social coding, because there is so much hate.

My head... it just did an ess'plode. Kudos

Re: Weekend project: A place to post crappy code. HatePaste

#18

Post by lurker17 » Mon, Mar 05, 2012, 9:04 PM UTC

biot wrote: post #10

It's interesting that this is one of the most hated ( http://hatepaste.com/paste/f5da3584 ): if (someBoolean == true) { doSomething(); } I got into the habit of doing this since it's immediately obvious that the value you're comparing is expected to be a boolean and not something like an integer, which could cause subtle bugs later on if what you thought was a boolean gets negated. More commonly, it's of the form: if…

Wow. http://www.paulgraham.com/avg.html

Re: Weekend project: A place to post crappy code. HatePaste

#19

Post by radicalbyte » Mon, Mar 05, 2012, 9:20 PM UTC

biot wrote: post #10

It's interesting that this is one of the most hated ( http://hatepaste.com/paste/f5da3584 ): if (someBoolean == true) { doSomething(); } I got into the habit of doing this since it's immediately obvious that the value you're comparing is expected to be a boolean and not something like an integer, which could cause subtle bugs later on if what you thought was a boolean gets negated. More commonly, it's of the form: if…

If you're going to do that, at least go the whole hog and avoid assignment/comparison bugs:

  if (true == someBoolean) {
    // code
  }

Re: Weekend project: A place to post crappy code. HatePaste

#20

Post by simon02 » Mon, Mar 05, 2012, 10:03 PM UTC

Looks nice. Quick note: please change the of color the timestamps and the categories, they are unreadable to me. Hardly even noticed they were there.