It would be nice if the author could fix this page, since the examples are incorrect and do not work as written. You need a space after the magic character.
Although I use it exactly as described (prefixing my search with the magic character followed by a space), it's not necessarily the best way to use it. If you can retrain your muscle memory, these shortcuts are better as suffixes. "% fish" will only show the open tabs (in the current container) with "fish" in them. "fish %" does the same, but when you've only typed the "fish" part, it will have the full set of search suggestions. Which are generally quite good in Firefox, and if what you're looking for is already in an open tab, it'll probably be in the list. But sometimes I don't remember if I have the tab open, so a history result would be better. With the suffix, you get the best of both worlds: the initial "fish" may show too many things, so tacking on "fish %" will restrict it to just the open tab results. That avoids doing it in two passes and having to go back and edit to remove the restriction token.
The actual feature is richer than you might think. It's only hinted at in https://support.mozilla.org/en-US/kb/address-bar-autocomplet... but there's actually a little DSL for queries. You can build these things up into filters. "% fish # github" will search for open tabs with github in their title. So if you can too many results (with eg "% fish"), you can filter them down incrementally (by tacking on " # github"). Yes, this disagrees with the previous suggestion; I'm back to prefixes here.
See https://firefox-source-docs.mozilla.org/browser/urlbar/nonte... for gory details of the address bar's operation in general, though it doesn't go into detail about the restriction tokens.