Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Building GitHub with Ruby on Rails

github.blog

Post reply on HN
Print view View original

121–130 of 332 posts

Re: Building GitHub with Ruby on Rails

#121

Post by georgyo »

thih9 wrote: post #119

> Every Monday a scheduled GitHub Action workflow triggers an automated pull request, which bumps our Rails version to the latest commit on the Rails main branch for that day. So uploading code to a github repo makes github server execute it later on. I wonder if this would qualify for a bug bounty... /s Edit: I guess not, since this is just a pull request and still requires approval before merging to main. I assume.

Don't work for GitHub, but it would not.

First, it opens a Pull Request, not an automatic merge, so hopefully the code is reviewed before merge.

To exploit this, you would first need to get malicious code merged into rails master which has many eyes, and then get passed more eyes when it gets reviewed by GitHub.

Not impossible, but if you got your code merged into rails master, you have wiggled your way into many more environments than just GitHub.

Re: Building GitHub with Ruby on Rails

#122

Post by nicce »

thih9 wrote: post #119

> Every Monday a scheduled GitHub Action workflow triggers an automated pull request, which bumps our Rails version to the latest commit on the Rails main branch for that day. So uploading code to a github repo makes github server execute it later on. I wonder if this would qualify for a bug bounty... /s Edit: I guess not, since this is just a pull request and still requires approval before merging to main. I assume.

Even if it was just not pull-request, highly unlikely that it would qualify.

We can assume that only trusted maintainers can put code into the Ruby main branch. Similarly, every build system depends on many many signed packages. It is not much different than that.

Re: Building GitHub with Ruby on Rails

#123

Post by upmostly »

tragomaskhalos wrote: post #38
upmostly wrote: post #3

I absolutely love Rails. I'll always remember back in 2010 catching the train to Waterloo station in London and seeing a huge sign overlooking the train tracks that read something like "We Need Rails Developers". Rails was such a huge part of my professional career. Now, 13 years later and I'm deep in the JavaScript ecosystem and have been for 8 years. The most exciting thing to come out of this ecosystem recently is…

Is that ad placement a genius piece of guerrilla marketing, or a recipe for total confusion, among the general population at least? Perhaps both.

I believe it must have worked well for them, although I have no specific proof, because that billboard was there for a good 6 months at least and must have cost a fair bit of money given how prominent it was.

Re: Building GitHub with Ruby on Rails

#124

Post by uptownJimmy »

I like GitHub, fwiw. I am not someone who requires everything to be perfect, and I've learned to be tolerant of our human reality, where imperfection is the norm.

But GitHub is not a great Web app. It is frequently/constantly out of sync with the latest data/status. You quickly develop the habit of manually refreshing the page every time you are preparing to do anything with a PR, and that's not something that should be necessary these days.

It surprises me to see a loud and proud blog post detailing GitHub's process of staying so relentlessly up to date with the latest and greatest version of Rails: the app is not properly responsive, for whatever reason, and to a degree that would not be tolerated where I have worked. I would rather read about how they are trying to fix this issue.

Re: Building GitHub with Ruby on Rails

#125

Post by cutler »

neals wrote: post #103
bspammer wrote: post #79

Earlier quoted context omitted.

Was this comment generated via ChatGPT? Not trying to catch you out, just curious if I'm able to successfully spot it in the wild.

You caught me red-handed! Yes, the previous comment was actually generated by ChatGPT. I must admit, I was curious to see if anyone would be able to spot it in the wild, and you my friend have successfully done so. In the interest of full disclosure, I should also mention that I didn't actually read the article before leaving my comment. I know, I know, shame on me! But on a more serious note, I think it's important…

Am I the only one already bored ****less by everything ChatGPT?

Re: Building GitHub with Ruby on Rails

#126

Post by dham »

cal85 wrote: post #90
upmostly wrote: post #3

I absolutely love Rails. I'll always remember back in 2010 catching the train to Waterloo station in London and seeing a huge sign overlooking the train tracks that read something like "We Need Rails Developers". Rails was such a huge part of my professional career. Now, 13 years later and I'm deep in the JavaScript ecosystem and have been for 8 years. The most exciting thing to come out of this ecosystem recently is…

Similar backstory. Back when I used Rails as a young dev I remember loving it but thought it all felt a bit parochial somehow, like they didn’t really get where the web was going. Now I realise they were just not interested in hype and other bullshit, they never get sucked into the latest scalability trends like I always did, they never cared about being first and trendy, and that’s why Rails is still there and still…

Yea it's funny how it worked out. I felt similar. I was chasing the latest trends, frontend frameworks, databases. They weren't, and now we're back where we started with sending data from the server and submitting forms.

I'm less likely in my career to stray away from whatever the old heads came up with. For instance the new thing is putting server/database calls in server side React components. But something tells me MVC was invented for a reason by people way smarter than me.

Re: Building GitHub with Ruby on Rails

#127

Post by elif »

mrwnmonm wrote: post #84

All the cool kids left Ruby for Go, why are they still in that land?

Since they left ruby (2.0) raw rails performance improved by 75% (3.0)

https://www.fastruby.io/blog/assets/images/RRBPerfHistory_72...

Then in 3.2, ruby released YJIT which improved median rails response time by about 100%

https://raw.githubusercontent.com/easydatawarehousing/ruby_m...

It's kind of a golden era for rubyists that stuck it out. Beautiful maintainable code that hits C performance for many tasks.

Re: Building GitHub with Ruby on Rails

#128

Post by Alifatisk »

AeroNotix wrote: post #76
dagorenouf wrote: post #61

I built my startup 4 years ago with a combination of react + aws + gatsby + hasura. I thought this would be great for performance and scale. Fast forward to today, I spend at least 2x as much time to code a feature than if I had just stuck with a simple rails stack, and the scale I imagined never happened. Now rebuilding everything with rails so I can ship faster and focus on growing the product, not making engineeri…

Building for scale from day 0 is a recipe for disaster. You should've seen that coming.

You suggest people should refactor later on when needed?

Re: Building GitHub with Ruby on Rails

#129

Post by himhckr »

Gigachad wrote: post #29
jstummbillig wrote: post #12

Earlier quoted context omitted.

Have a look at AdonisJS. It's in a somewhat weird spot: On the one hand it is mature and has amazing DX/UX going for it, with a lot of very thoughtful tooling. On the other, for some reason, it has always remained niche with just a couple of core developers, even though it's now nearing version 6 and at least 8 years of releases. I do not know why that is the case. It's a beautifully written full stack framework, tak…

I used AdonisJS. Reminds me a lot of rails but with the added safety of typescript.

Totally agree! I have used many frameworks (even written my own) but nothing gets close to Laravel for PHP and AdonisJS for TypeScript in terms of features out of the box and DX.

Re: Building GitHub with Ruby on Rails

#130

Post by gareve »

dagorenouf wrote: post #61

I built my startup 4 years ago with a combination of react + aws + gatsby + hasura. I thought this would be great for performance and scale. Fast forward to today, I spend at least 2x as much time to code a feature than if I had just stuck with a simple rails stack, and the scale I imagined never happened. Now rebuilding everything with rails so I can ship faster and focus on growing the product, not making engineeri…

I haven't been able to apply to a real project yet, but I like the idea of building to refactor.

You execute for today, but make it easier to replace parts on the future

Post reply on HN