Live data from Hacker News

GitHub Desktop 3.2: Preview your pull request

github.blog

61–70 of 72 posts

Re: GitHub Desktop 3.2: Preview your pull request

#61
post #59
post #55

Earlier quoted context omitted.

https://github.com/gitx/gitx/releases my daily driver in mac

Huh, it was just accepted as the mainline fork in Homebrew last week! Been trying it and it seems to have all the features that the rowanj fork had! https://github.com/Homebrew/homebrew-cask/pull/141659

Been using GitX for many years . Happy to learn there’s a new fork. Thanks!

Re: GitHub Desktop 3.2: Preview your pull request

#62

If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restor…

Plenty of git commands support a -p mode. I like `git stash -p`.

Re: GitHub Desktop 3.2: Preview your pull request

#63

If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restor…

Interesting, I knew of `git add -p` (which I then use to `git commit -m ...`, but it looks like I could add all changes and _then_ decide what to commit. I think I'd still use `add -p` (I like being thorough), but I like that I can add all at once and then make partial commits based on specific change sets. Thanks for pointing this out, I feel like git is the thing I should know best by now yet I'm missing so much of…

My favorite git workflow extension is `git commit --fixup SHA` combined with `git rebase -i --autosquash` to create targeted retroactive amendments. Kind of like `commit --amend that can target more than just the last commit.

I wrote https://github.com/brasic/fixdown to make this easier to use.

Re: GitHub Desktop 3.2: Preview your pull request

#64
post #42

Earlier quoted context omitted.

>> So basically, now we can do `git diff master` in a GUI. > One thing I do like a lot is that the diff I see is exactly what my code reviewers will see. What will they see in the diff that you can see using Github Desktop that you wouldn't see by running git diff master?

Colors and fonts especially. After ten years my brain is fast at reading a GitHub diff. It’s pretty slow at reading a terminal diff because I don’t do it very much.

Presumably most people use an editor or IDE for coding and it's likely that editor or IDE could also be used to display diffs, so I don't really see colors or fonts being an issue. The IDE or editor could also be configured to use colors and fonts similar to what's used in Github. For example, vim has a colorscheme[1] that's similar to what Github offers.

[1] https://github.com/cormacrelf/vim-colors-github

Re: GitHub Desktop 3.2: Preview your pull request

#65

GitHub desktop/mobile apps have been the worst thing to happen to GH since / along with the acquisition. The website is being neglected, (especially on mobile) which is the primary value the service has for me. If I have `git` I really don't need GitHub except to view comments. Ironically, notifications and comment management is still pretty bad. Don't get me wrong, I still think GitHub is the best at what they do, b…

I would use more non-GitHub solutions if they had GitHub Desktop or equivalent. The number of accidental commits I've seen by long term industry experts demonstrates that command line isn't always the best for all things. I generally avoid opening PRs on machines I don't have Desktop, which is why it's such an embarrassment GitHub has refused to publish an official Linux version, despite an employee maintaining one f…

> despite an employee maintaining one for years.

Mind sharing where I can get this?

Re: GitHub Desktop 3.2: Preview your pull request

#66
post #65

Earlier quoted context omitted.

I would use more non-GitHub solutions if they had GitHub Desktop or equivalent. The number of accidental commits I've seen by long term industry experts demonstrates that command line isn't always the best for all things. I generally avoid opening PRs on machines I don't have Desktop, which is why it's such an embarrassment GitHub has refused to publish an official Linux version, despite an employee maintaining one f…

> despite an employee maintaining one for years. Mind sharing where I can get this?

Here: https://github.com/shiftkey/desktop

Re: GitHub Desktop 3.2: Preview your pull request

#67

Earlier quoted context omitted.

You're missing my point. I don't want all the new features. I want the existing ones taken care of and polished.

In one comment, you say the webapp is abandoned. In another, you say it gets too many new features you don’t care about. If the latter is true, the former is definitely not true. That’s the main reason you’re getting some flack in this thread!

Sorry, let me be clear. Existing features feel abandoned and neglected. CSS styles are getting out of whack, margins and padding are way off in many places as they shoehorn in new features.

You can neglect something's foundation while strapping new bells and whistles on.

Re: GitHub Desktop 3.2: Preview your pull request

#69

Sublime Merge is still the best option so far (not Electron)

People on my team use it. I guess it's fine, but when they get stuck with git (a-la locate git.txt and call the number listed on it), I am sort of at a loss of what they did to get where they are. At least with git commands you can sort of see how they got there. Just my 2c

Sublime Merge presents every single action taken as a git command (and presents a history of them and the results of each one)

Also git reflog?

Re: GitHub Desktop 3.2: Preview your pull request

#70

Earlier quoted context omitted.

In one comment, you say the webapp is abandoned. In another, you say it gets too many new features you don’t care about. If the latter is true, the former is definitely not true. That’s the main reason you’re getting some flack in this thread!

Sorry, let me be clear. Existing features feel abandoned and neglected. CSS styles are getting out of whack, margins and padding are way off in many places as they shoehorn in new features. You can neglect something's foundation while strapping new bells and whistles on.

Let me be clear, Primer is a UI kit, not a feature, so if they're working on polishing the UI kit, which we can all see that they are, then they're doing what you're asking them to do. Again, fact over perception because the commits and activity are telling a completely different story.

https://github.com/primer

I think github looks fairly nice/modern given it's age and I'm not having issues or feeling like anything is "abandoned". All I'm hearing is hyperbole.

Post reply on HN