Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

GitHub Desktop 3.2: Preview your pull request

github.blog

Post reply on HN
Print view View original

41–50 of 72 posts

Re: GitHub Desktop 3.2: Preview your pull request

#41

Post by jonas-w »

btown wrote: post #31
heydenberk wrote: post #12

If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restor…

For those who want a GUI around this on Mac, https://rowanj.github.io/gitx/ is an incredible secret weapon. You can swipe over a bunch of lines or let the software identify a whole span of contiguous changed lines, click a button, and see just those changes move over from your unstaged to staged changes, then commit exactly what you want. A lot of times people don't even understand how powerful the staging area is; t…

According to this issue[0] there is a newer and maintained version of gitx.

[0] https://github.com/rowanj/gitx/issues/481

Re: GitHub Desktop 3.2: Preview your pull request

#42

Post by u801e »

ripplefringe wrote: post #26
nusaru wrote: post #2

So basically, now we can do `git diff master` in a GUI. Hooray, I guess.

I use Github Desktop. One thing I do like a lot is that the diff I see is exactly what my code reviewers will see. Personally, I spend a lot of time reviewing other's code ad also going through my own PR's in Github. I'm very familiar with that view. I think it helps my brain that I use the same diff view when I'm working locally and when I'm reviewing code on Github.

>> So basically, now we can do `git diff master` in a GUI.

> One thing I do like a lot is that the diff I see is exactly what my code reviewers will see.

What will they see in the diff that you can see using Github Desktop that you wouldn't see by running git diff master?

Re: GitHub Desktop 3.2: Preview your pull request

#43

Post by u801e »

randyrand wrote: post #6
nusaru wrote: post #2

So basically, now we can do `git diff master` in a GUI. Hooray, I guess.

The UI for the diff is actually useful though. Much easier to read and browse than a terminal.

I've found piping the output of git diff to my editor makes it much easier to browse compared to using the UI. For instance, searching for a particular file or line of code it much easier in the editor compared to the browser.

Re: GitHub Desktop 3.2: Preview your pull request

#44

Post by tomschlick »

Symbiote wrote: post #39
tomschlick wrote: post #19

Earlier quoted context omitted.

You can commit line by line within Github Desktop and its a much nicer experience IMO than doing so via CLI. Its much easier to jump around to different files and commit related line changes in a bigger PR than jumping in and out of the patch command.

git gui which you probably already have if you use Linux also has this functionality.

It does, but github desktop is way better looking and has deeper integration into github prs, status checks, etc.

Re: GitHub Desktop 3.2: Preview your pull request

#45

Post by ripplefringe »

u801e wrote: post #42
ripplefringe wrote: post #26

Earlier quoted context omitted.

I use Github Desktop. One thing I do like a lot is that the diff I see is exactly what my code reviewers will see. Personally, I spend a lot of time reviewing other's code ad also going through my own PR's in Github. I'm very familiar with that view. I think it helps my brain that I use the same diff view when I'm working locally and when I'm reviewing code on Github.

>> So basically, now we can do `git diff master` in a GUI. > One thing I do like a lot is that the diff I see is exactly what my code reviewers will see. What will they see in the diff that you can see using Github Desktop that you wouldn't see by running git diff master?

Colors and fonts especially. After ten years my brain is fast at reading a GitHub diff. It’s pretty slow at reading a terminal diff because I don’t do it very much.

Re: GitHub Desktop 3.2: Preview your pull request

#46

Post by calvinmorrison »

coldblues wrote: post #9

Sublime Merge is still the best option so far (not Electron)

People on my team use it. I guess it's fine, but when they get stuck with git (a-la locate git.txt and call the number listed on it), I am sort of at a loss of what they did to get where they are. At least with git commands you can sort of see how they got there.

Just my 2c

Re: GitHub Desktop 3.2: Preview your pull request

#47

Post by joshcanhelp »

nixpulvis wrote: post #37
bastardoperator wrote: post #28

Earlier quoted context omitted.

Facts over perception, go look at changelog, look at primer... The Web UI gets new features almost daily.

You're missing my point. I don't want all the new features. I want the existing ones taken care of and polished.

I agree that I don’t need most of the new features but, in my experience working with it almost daily, the web experience has only gotten better for me in the last year or more.

Re: GitHub Desktop 3.2: Preview your pull request

#48

Post by noahtallen »

nightpool wrote: post #33
nixpulvis wrote: post #7

GitHub desktop/mobile apps have been the worst thing to happen to GH since / along with the acquisition. The website is being neglected, (especially on mobile) which is the primary value the service has for me. If I have `git` I really don't need GitHub except to view comments. Ironically, notifications and comment management is still pretty bad. Don't get me wrong, I still think GitHub is the best at what they do, b…

"The website is being neglected"—really? Compared to their complete feature freeze pre-acquisition, new Github platform features come out regularly (WIP PRs, code owners, the entire Actions and Codespaces products, and Merge Queue being the most recent one). I've never used Github Desktop, but the idea that the website is being neglected just doesn't make any sense to me.

Not to mention more in-depth notification management, much better code search, and significantly improved code browsing! (Examples of polished features.) I have been pretty impressed at the pace of new features over the past two plus years.

Re: GitHub Desktop 3.2: Preview your pull request

#49

Post by noahtallen »

nixpulvis wrote: post #37
bastardoperator wrote: post #28

Earlier quoted context omitted.

Facts over perception, go look at changelog, look at primer... The Web UI gets new features almost daily.

You're missing my point. I don't want all the new features. I want the existing ones taken care of and polished.

In one comment, you say the webapp is abandoned. In another, you say it gets too many new features you don’t care about. If the latter is true, the former is definitely not true. That’s the main reason you’re getting some flack in this thread!
Post reply on HN