Live data from Hacker News

GitHub Desktop 3.2: Preview your pull request

github.blog

11–20 of 72 posts

Re: GitHub Desktop 3.2: Preview your pull request

#11
post #8

Earlier quoted context omitted.

The UI for the diff is actually useful though. Much easier to read and browse than a terminal.

You're not wrong. Personally, I just used GitHub's web UI to preview my PRs, but I suppose having a local GUI makes it easier to amend commits and not have to force push changes.

Electron apps eat my ram and web UIs run like shit when backed by a large private instance.

Re: GitHub Desktop 3.2: Preview your pull request

#12
If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restore.) If you have, for example, two pairs of backend/frontend changes that you want to commit logically rather than simply according to their directory structure, partial committing is handy.

It's just `git commit -p` (and `git checkout -p`). It's not exactly a deep cut, but I encourage people who are familiar but don't use it to give it a try.

Re: GitHub Desktop 3.2: Preview your pull request

#13

GitHub desktop/mobile apps have been the worst thing to happen to GH since / along with the acquisition. The website is being neglected, (especially on mobile) which is the primary value the service has for me. If I have `git` I really don't need GitHub except to view comments. Ironically, notifications and comment management is still pretty bad. Don't get me wrong, I still think GitHub is the best at what they do, b…

The worse thing to happen to GH? Really?

Using git on the command line can be hard to learn and unintuitive for people - the desktop client makes things easier and that's a good thing (kind of like how the GUI made computers accessible to more people and ended up benefiting everyone in software...)

Re: GitHub Desktop 3.2: Preview your pull request

#14

GitHub desktop/mobile apps have been the worst thing to happen to GH since / along with the acquisition. The website is being neglected, (especially on mobile) which is the primary value the service has for me. If I have `git` I really don't need GitHub except to view comments. Ironically, notifications and comment management is still pretty bad. Don't get me wrong, I still think GitHub is the best at what they do, b…

I would use more non-GitHub solutions if they had GitHub Desktop or equivalent. The number of accidental commits I've seen by long term industry experts demonstrates that command line isn't always the best for all things. I generally avoid opening PRs on machines I don't have Desktop, which is why it's such an embarrassment GitHub has refused to publish an official Linux version, despite an employee maintaining one for years.

Re: GitHub Desktop 3.2: Preview your pull request

#15

If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restor…

Interesting, I knew of `git add -p` (which I then use to `git commit -m ...`, but it looks like I could add all changes and _then_ decide what to commit. I think I'd still use `add -p` (I like being thorough), but I like that I can add all at once and then make partial commits based on specific change sets.

Thanks for pointing this out, I feel like git is the thing I should know best by now yet I'm missing so much of what it can do. It's great to see others' workflows.

Re: GitHub Desktop 3.2: Preview your pull request

#16

Sublime Merge is still the best option so far (not Electron)

Absolutely, what an excellent tool. One of those one-time purchases I almost wish was a subscription so I can be sure the team keeps working on it.

I actually understand git better because of Merge. It's great because it provides a great interface into git, but it doesn't _hide_ git from you; it explains it quite a well.

I suppose a newcomer to git might find Merge intimidating, but for anyone with a bit of experience I think it's quite an awesome power tool with a rare balance of handy abstraction and transparency around git itself.

Re: GitHub Desktop 3.2: Preview your pull request

#17
post #8

Earlier quoted context omitted.

You're not wrong. Personally, I just used GitHub's web UI to preview my PRs, but I suppose having a local GUI makes it easier to amend commits and not have to force push changes.

Electron apps eat my ram and web UIs run like shit when backed by a large private instance.

It was mentioned elsewhere but you might find Sublime Merge to be useful; it's not based on Electron, it's very fast, and it makes working with various git workflows a lot nicer (to me, at least).

Re: GitHub Desktop 3.2: Preview your pull request

#18

GitHub desktop/mobile apps have been the worst thing to happen to GH since / along with the acquisition. The website is being neglected, (especially on mobile) which is the primary value the service has for me. If I have `git` I really don't need GitHub except to view comments. Ironically, notifications and comment management is still pretty bad. Don't get me wrong, I still think GitHub is the best at what they do, b…

Github Desktop is the best thing to happen to GH for me. Makes my workflow so much nicer.

Re: GitHub Desktop 3.2: Preview your pull request

#19

If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restor…

You can commit line by line within Github Desktop and its a much nicer experience IMO than doing so via CLI. Its much easier to jump around to different files and commit related line changes in a bigger PR than jumping in and out of the patch command.

Re: GitHub Desktop 3.2: Preview your pull request

#20

If you get a lot of value out of the pull request view, you might enjoy adding partial committing to your workflow. Rather than committing entire directories or folders at a time, you can page chunk by chunk through uncommitted changes, committing only the ones you select. You'll easily spot those stray logging statements you don't want to commit. (You can also discard chunk at a time by using partial checkout/restor…

Interesting, I knew of `git add -p` (which I then use to `git commit -m ...`, but it looks like I could add all changes and _then_ decide what to commit. I think I'd still use `add -p` (I like being thorough), but I like that I can add all at once and then make partial commits based on specific change sets. Thanks for pointing this out, I feel like git is the thing I should know best by now yet I'm missing so much of…

I've tended to have a similar workflow... but since I use VS Code mostly, then I do use the git tab a lot for previewing changes before committing them. Other than that, I've mostly avoided using any GUI for git, mostly because I find it annoying. I'll say that the Github client and the VS Code integrations for Github have come a long way all the same for those that use and like them.
Post reply on HN