Uff, I might have been that guy!
I think it came about from my first couple of tech jobs in which I was either working alone or was the most knowledgeable one on the team and thus pretty much anything I said happen. When I came to work with teams I’d “care too much” as in I’d want functions to be called in a certain way, or logic to be split is X or Y way, or some other random thing to be implemented in a specific way.
Not only was that, I’m sure, very annoying to my coworkers but it also brought be a lot of anxiety. I had this stupid idea that “I knew” and others only “knew” as long as they agreed with my knowledge.
I’ve come to realize that that is quite stupid and a huge source of stress that I could just cut away!
As a policy nowadays I accept pretty much any opinions or changes to my PR as long as is not something that actually affect the product. I remember once having elevating a disagreement all the way to the CTO about a variable name! so, no, a coworker things that X should be called Y? For sure! That we should use .forEach instead of a for loop? No problem!
I don’t own that code, we as a team do, and thus I no longer “care”.
Don’t get me wrong, I still have opinions and share those as needed, but I’ve come to realize that there are many ways to accomplish the same thing, that “elegance” is not really a value that business holds in high regard (business == $$), and that getting stuff done and getting along makes me as an engineer very valuable to the company.
I nitpick on my personal projects, I write “elegant” (at least my definition of it) code for my editor config file, and I’m way happier that way!