PR that converts the TypeScript repo from namespaces to modules

Post by shepherdjerred » Wed, Nov 02, 2022, 11:56 PM UTC

spartanatreyu wrote: post #107

robbick wrote: post #63

Earlier quoted context omitted.

I can see this is probably a calm point that will definitely not escalate, programmers don't really care about tabs and spaces that much, right???

"Tabs vs spaces" is often misunderstood (and falsely reported) as a problem of preference. The real problem is that using spaces for indentation is an accessibility issue. The solution is to use tabs for indentation, and spaces for alignment.

Post by sesm » Thu, Nov 03, 2022, 12:08 AM UTC

jakebailey wrote: post #35

berkes wrote: post #23

Earlier quoted context omitted.

I'm curious about that too. From my superficial knowledge of compilers, "modularization" itself should not make code faster, if anything slower. There'll always be some overhead of loading modules and communicating between them, not? I presume, from my own experience when building software (not compilers), that modules allow for a much easier to reason about, much better isolated (cohesion, loose coupling). And there…

There are some key things here that maybe weren't clearly stated in my writeup. Firstly, the old codebase is TS namespaces, which compile down to IIFEs that push properties onto objects. Each file that declares that namespace is its own IIFE, and so every access to other files incurs the overhead of a property access. With modules, tooling like esbuild, rollup, can now actually see those dependencies (now they are st…

Post by shepherdjerred » Thu, Nov 03, 2022, 12:31 AM UTC

__s wrote: post #48

longrod wrote: post #8

Sucrase is proof that JS is not the problem when it comes to slow performance. JS is not slow. NodeJS is not slow. It's the code that is slow. All these people wanting to write it in Rust or Go or XYZ programming language need to acknowledge this. Yes, multithreading is awesome and really helpful but it's the cherry on top, not the whole thing. If the same amount of effort was put into optimizing the TSC codebase as…

I rewrote a card game engine, openEtG, from JS to Rust. It was a pretty 1:1 rewrite. 2x improvement even when I was using HashMap everywhere. I've since entirely removed HashMap, which has only further improved perf As a bonus, the code is now statically typed

Post by shepherdjerred » Thu, Nov 03, 2022, 12:37 AM UTC

KingOfCoders wrote: post #3

Quoted post unavailable.

Post by satvikpendem » Thu, Nov 03, 2022, 12:51 AM UTC

shepherdjerred wrote: post #116

satvikpendem wrote: post #79

Earlier quoted context omitted.

> but typescript developers will not learn rust to improve the typescript compiler. Why not? TS has much more in common with Rust than with JS, in terms of typing. Compiler engineers are not that prevalent in the community, but they are much more prevalent in the systems engineering world which Rust is a part of, so I'd assume it's actually more beneficial to have a compiler in Rust than in TS because it would mean m…

> TS has much more in common with Rust than with JS, in terms of typing. TS has much more in common with JS than it does with Rust in every other comparison Every TS dev will know at least a little bit of JS. Not every TS dev will know Rust at all. They're very different languages.