I think there are multiple things going on here that the professor doesn’t seem to grasp:
1) The pandemic response of schools completely disrupted the learning level and style of an entire generation of kids for two years, and we’re now seeing the downstream impact of that.
2) I’m pretty sure that compared to 20 years ago, the more capable students are using AP Econ to test out of the college intro course, so you would expect the average interest and effort level of the remaining students to naturally decline.
3) I’m having trouble parsing this statement: “As a result, the student experience increasingly diverges from that of other courses, in which students feel a higher level of comfort, receive greater affirmation of their opinions, and earn higher grades.” But on the surface it seems to match a trend I noticed in college where students are optimizing for easy grades instead of for actual learning.
4) It really seems like the academic field of macroeconomics stopped matching reality in 2008 and now an entire generation of kids have grown up mistrusting economists and policy makers for good reasons.