Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Who wrote this shit?

heltweg.org

Post reply on HN
Print view View original

181–190 of 300 posts

Re: Who wrote this shit?

#181

Post by bikingbismuth »

DarylZero wrote: post #109
bikingbismuth wrote: post #44

In my first corporate job out of college (a NOC at an ISP) I was asked to update the documentation for troubleshooting quality of service issues. I checked our wiki for what was already there and it horrendous. I started to mentally thrash the person and was going to go confront them about it. When I checked the edit history I was greeted by a single edit and my username a week after I started the job. I learned a gr…

Well anyone would be pissed if the only documentation was written by some asshole on his first week.

Completely agree. My manager at the time thought it was a brilliant idea to have new people write the wiki when they started, because “they just learned the right way to do it from a senior person!”. This is not something I took with me into my own transition to management.

Re: Who wrote this shit?

#182

Post by klyrs »

rozenmd wrote: post #4

My favourite is when you're a solopreneur working in your own repos and still asking yourself "who wrote this shit?!"

Haha, yeah. My reaction to the title was "my past self, usually." I've seen utterly horrible code written by people who I consider myself leagues beneath. Sometimes git blame is a lesson in humility.

Re: Who wrote this shit?

#183

Post by hutzlibu »

trixie_ wrote: post #180
hutzlibu wrote: post #174

Earlier quoted context omitted.

Erm, you realize that it was YOU, who ignored the essential parts of my comment, proofing my point? Apparently not. Otherwise, sure: "Is it because YOU ignored them and didn't update them with code changes? Or others did so and it got past a code review? " Both happened. And I doubt this never happened to you. And if it really never happened to you - then you either are a superhuman - or never had to ship lots of cod…

It does happen, but it is the exception and not the rule. If you're entire argument hinges on the exception case then I'd rethink your position.

My entire argument is, on average there are way too many dead comments around and I would rather recommend to people using comments as exception where the code is not clear enough, to decrease the burden of maintaining them and rather focus to keep the proper higher level documentation up to date and readable.

Re: Who wrote this shit?

#184

Post by blindmute »

Am I the only one who just... writes good code? I look back on code from when I was a junior and sure, it's bad. But code from 4 years ago? It's still perfectly fine. I don't believe that it's normal for long-time seniors to think their code from only a year ago is consistently bad, yet there are a lot of comments in here to that effect.

Re: Who wrote this shit?

#185

Post by psyc »

blindmute wrote: post #184

Am I the only one who just... writes good code? I look back on code from when I was a junior and sure, it's bad. But code from 4 years ago? It's still perfectly fine. I don't believe that it's normal for long-time seniors to think their code from only a year ago is consistently bad, yet there are a lot of comments in here to that effect.

No, you're not the only one. It's just generally not advisable to say so here (or worse, on Reddit) because the bucket-crabs will getcha.

FWIW, I did write atrocious code when I was 16. But I'm in my 40's now.

Re: Who wrote this shit?

#187

Post by taocoyote »

matwood wrote: post #137
bikingbismuth wrote: post #44

In my first corporate job out of college (a NOC at an ISP) I was asked to update the documentation for troubleshooting quality of service issues. I checked our wiki for what was already there and it horrendous. I started to mentally thrash the person and was going to go confront them about it. When I checked the edit history I was greeted by a single edit and my username a week after I started the job. I learned a gr…

Always check git blame before winging out insults. Then, only blame people no longer at the company ;)

Find incomprehensible code. Get email from blame. Search for them on Linkedin. If they are working as a developer in some senior capacity, then the code is probably a learning opportunity for me. If they are working as a scrum master code is probably as bad as it looks.

I say this in jest, mostly...

Re: Who wrote this shit?

#188

Post by terafo »

matwood wrote: post #137
bikingbismuth wrote: post #44

In my first corporate job out of college (a NOC at an ISP) I was asked to update the documentation for troubleshooting quality of service issues. I checked our wiki for what was already there and it horrendous. I started to mentally thrash the person and was going to go confront them about it. When I checked the edit history I was greeted by a single edit and my username a week after I started the job. I learned a gr…

Always check git blame before winging out insults. Then, only blame people no longer at the company ;)

You should check out GitLens for VSCode, it makes the process of working with git blame seamless.

Re: Who wrote this shit?

#189

Post by DiggyJohnson »

HalcyonCowboy wrote: post #121
justinmchase wrote: post #100

Earlier quoted context omitted.

On the other end, it's fun when you encounter a bug and go search for an answer and end up reading an answer on Stack Overflow that _you wrote_ 5 years ago and totally forgot about it.

Haha, this happened to me for the first time recently. Asked a question, didn’t get any answers, ended up updating my post with the answer I eventually found. Even had a couple of responses thanking me for the follow up. Five years later, ran into the same problem and forgot the answer, my answer was the top result on google.

I was once looking to see if there were any projects or discussions regarding via the google search " Hacker News". I clicked on the top link because, read the comment, and was annoyed that it didn't actually address the things I wanted it to.

Then I realized I wrote the comment. I didn't address the things because I was looking for it then and I'm stilling looking for it.

Re: Who wrote this shit?

#190

Post by honkycat »

I always say: "Code happens."

Software quality cannot be pinned to a single individual. Software quality emerges from your software development process.

So, for me, it is more: "Who approved this shit?"

Post reply on HN