Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: Mako – a full Bitcoin implementation in C

github.com

Post reply on HN
Print view View original

1–10 of 129 posts

Re: Show HN: Mako – a full Bitcoin implementation in C

#3

Post by chjj »

tmaly wrote: post #2

This looks super interesting. One thing that kinda bothers me is that most of the tests are just #include #include #include #include "lib/tests.h" int main(void) { return 0; }

Yeah, I'm embarrassed about that. It's way behind on tests.

The past 2 months of limited sleep were a massive scramble just trying to get everything implemented and trying to get the damn thing to sync properly. Things seem to work in practice, but it's very scary not having high test coverage, especially with a project like this. Now that everything has solidified and my sleep schedule has normalized a bit, it's my intention to take the time to write proper tests.

Re: Show HN: Mako – a full Bitcoin implementation in C

#7

Post by brighton36 »

chjj wrote: post #3
tmaly wrote: post #2

This looks super interesting. One thing that kinda bothers me is that most of the tests are just #include #include #include #include "lib/tests.h" int main(void) { return 0; }

Yeah, I'm embarrassed about that. It's way behind on tests. The past 2 months of limited sleep were a massive scramble just trying to get everything implemented and trying to get the damn thing to sync properly. Things seem to work in practice, but it's very scary not having high test coverage, especially with a project like this. Now that everything has solidified and my sleep schedule has normalized a bit, it's my…

Did you learn that 'the implementation is the spec' ? (Does that mean Bitcoin is fiat?)

Re: Show HN: Mako – a full Bitcoin implementation in C

#8

Post by zackham »

This looks like a herculean effort over just the past few months. Congratulations on hitting this milestone and hopefully you can take a breather and tie up loose ends at a more comfortable pace. As much as HN has changed over the years I still think this is a place where there are a lot of people who can appreciate how you feel right now. Nicely done!

Re: Show HN: Mako – a full Bitcoin implementation in C

#10

Post by arcticbull »

chjj wrote: post #5
beebmam wrote: post #4

Some of this C code looks extremely obfuscated. Not a fan.

Do you mind elaborating? I obsess over clean code, so any criticism is appreciated.

It looks super clean to me, the only exception being for the love of all that's good and holy always brace your one-line if statements and loops.

You don't want your own "goto fail" do you? ;) [1]

I think you did a great job.

[1] https://nakedsecurity.sophos.com/2014/02/24/anatomy-of-a-got...

Post reply on HN