Earlier quoted context omitted.
> But there is much noise to filter through in the many tools we juggle these days, especially if an organization prefers to self-host. If an organization is too overloaded to patch for six months, maybe they should re-evaluate if self-hosting is the best course of action. Seems like this is a foot-gun of your own creation.
There is very little reason to even self host Gitlab unless you are insanely paranoid or for philosophy reasons like debian/gnome.
Gitlab servers are being exploited in DDoS attacks
91–100 of 177 posts
Re: Gitlab servers are being exploited in DDoS attacks
#92Earlier quoted context omitted.
The line existed in the 2014 commit which migrated the repo to git. It wasn't designed in the current era of mass automated abuse and internet connected everything.
2014 was very much that era, I'd accept this excuse maybe for 2007
I'd accept this for maybe pre-2000, but people should really know better.
Re: Gitlab servers are being exploited in DDoS attacks
#93Earlier quoted context omitted.
> File uploads remain one of the hardest problems to solve when it comes to security. Why? It seems like they should have read/write but no execute. What goes wrong?
You essentially have a gateway into a very large chunk of code that was most likely not built with security in mind on the parsing side, on top of that you are guaranteed write access to some file system.
1. No filesystem access
2. No network access
3. Input passed on stdin (or a pre-opened fd)
4. Output passed to stdout (or a pre-opened fd)
5. A hard timeout specified before the process is killed
Suddenly bam, dramatically safer.
If you're looking for a tool that can do all of this for you, check out firejail:
https://firejail.wordpress.com/
It has a ton of options, but you can do all of what I suggested and more, really easily.
Re: Gitlab servers are being exploited in DDoS attacks
#94Re: Gitlab servers are being exploited in DDoS attacks
#95Earlier quoted context omitted.
Not him, but how are you supposed to know about the update? Do you need to check some page every day if there's an update? Why can't security updates just autoupdate like apps on phones or at least email the admin saying there is an important update.
Yes, you are meant to be paying attention to the security news for all tools you self host. That's part of self hosting. If you can't manage that (which is completely fair), then you shouldn't be self hosting.
I once had a CVE RSS feed, but it was mostly noise even after I filtered it to only tools/libraries we used.
Re: Gitlab servers are being exploited in DDoS attacks
#96Would putting your Gitlab instance behind a VPN mitigate this issue and similar? At least, it would limit attackers to malicious people with VPN access.
It would dramatically limit your attack surface to those who could gain access to your VPN. I prefer requiring TLS mutual authentication with a corporate PKI and issuing employees client certificates. Doing both wouldn't be a bad idea either.
Re: Gitlab servers are being exploited in DDoS attacks
#97Earlier quoted context omitted.
My personal career favorite use of eval was for an import system that "unrolled" the loop that went through the columns for each row, using eval. It was much faster, but obviously a huge security risk. Today with modern JIT compilers its probably not much faster...
I was once tasked with creating a new frontend on an old project that had an API endpoint return something like this: var array = ["foo", "bar"] I was expecting xml or json (like the rest of the endpoints), but I realized that they just served this as text, and then eval'd it on the frontend...
Re: Gitlab servers are being exploited in DDoS attacks
#98Earlier quoted context omitted.
> But there is much noise to filter through in the many tools we juggle these days, especially if an organization prefers to self-host. If an organization is too overloaded to patch for six months, maybe they should re-evaluate if self-hosting is the best course of action. Seems like this is a foot-gun of your own creation.
There is very little reason to even self host Gitlab unless you are insanely paranoid or for philosophy reasons like debian/gnome.
Suffice to say, we fall under "insanely paranoid".
Re: Gitlab servers are being exploited in DDoS attacks
#99Earlier quoted context omitted.
Anyone who can open issues in a repo I think
I am confused by this right now. I built a self-hosted gitlab install years ago for my own use, turned off sign-up, no public project listings - and still it was compromised. The HackerOne PoC URL throws a sign-in redirect for me, so I'm still trying to work it out.
Re: Gitlab servers are being exploited in DDoS attacks
#100Earlier quoted context omitted.
My personal career favorite use of eval was for an import system that "unrolled" the loop that went through the columns for each row, using eval. It was much faster, but obviously a huge security risk. Today with modern JIT compilers its probably not much faster...
I was once tasked with creating a new frontend on an old project that had an API endpoint return something like this: var array = ["foo", "bar"] I was expecting xml or json (like the rest of the endpoints), but I realized that they just served this as text, and then eval'd it on the frontend...