Live data from Hacker News

Terraform is currently not reviewing community pull requests

github.com

91–100 of 120 posts

Re: Terraform is currently not reviewing community pull requests

#92
post #61

Earlier quoted context omitted.

There are many projects where just doing that would be the equivalent of a full time position. Even saying no requires a skilled review.

Is there no way to just have a script add a comment on every new PR saying "Due to insufficient staff, your PR may not be reviewed for a considerable amount of time."?

I think the issue is about letting people know that PRs won't be reviewed/merged before they bother putting a lot of effort into them (both the commit itself and setting up/documenting the PR).

Re: Terraform is currently not reviewing community pull requests

#93
post #53

Earlier quoted context omitted.

I work at AWS. The service teams do own and write their CloudFormation providers, although if you've written a custom provider you'd see it is somewhat clunky, so it's sometimes considered more of an operational burden, and you can tell. We dogfood both the SDK and CloudFormation internally, we just deal with its numerous gripes much the same way you would externally (although we can also contact service teams direct…

Million dollar question would be if all the “feature requests” that AWS support opens when they don’t know what else to do actually go someplace or if they just get swept aside every few days. I’ve always been under the impression they receive very little or no attention. Even bugs where I have included a reproducible test case that results in an internal error, they just keep trying to close the ticket every few day…

I work for AWS. We have an internal tracking system containing customer feature requests, and our service teams review them biweekly and they get prioritized by product management. “Working backwards from the customer” is gospel here.

Re: Terraform is currently not reviewing community pull requests

#94
post #85

Earlier quoted context omitted.

Are you really open source in spirit at that point though?

Yes. Both the cathedral and the bazaar are valid approaches to OSS project management, with pros and cons.

For those curious apart from myself:

Cathedral -> centralized control Bazaar -> decentralized control

https://opensource.stackexchange.com/questions/511/whats-the...

Re: Terraform is currently not reviewing community pull requests

#95
post #6

These things happen, props to Hashicorp for communicating about it. It would be easy to say that this is a failure of open-source in some way, but to do so would be unfair to the huge amount of work that companies put into tools like this, and the stewardship that they offer, both of which take a lot of time and money. If periods of low activity while teams change are the cost the community needs to pay for that, I t…

I had a conversation with my coworkers when I worked there about being upfront with folks that we wouldn't review or accept their PR and stop leaving people hanging (this was on the TFE provider). I'm glad this was added. I stand by my statement then and now: there is nothing worse than contributing to something open source and then have your PR completely ignored.

> I stand by my statement then and now: there is nothing worse than contributing to something open source and then have your PR completely ignored

Really? Nothing worse?

Re: Terraform is currently not reviewing community pull requests

#96
post #61

Earlier quoted context omitted.

Is there no way to just have a script add a comment on every new PR saying "Due to insufficient staff, your PR may not be reviewed for a considerable amount of time."?

Your code is important to us. Please stay on the line, and the next available reviewer will answer your code. Due to unusually high code volumes, this response may take longer than usual. Something like that?

All that's missing is an autoplay embed with some hold muzak ;-)

Re: Terraform is currently not reviewing community pull requests

#97

Earlier quoted context omitted.

heh. i've been considering a switch from ansible to terraform because i've been frustrated by ansible's limited support for some of the edge cases around ALBs. good to hear that terraform also sucks. i'm gradually coming to the conclusion that all the tools that are supposed to make provisioning cloud infrastructure easier aren't as good as a bunch of crappy custom scripts using boto or aws-cli.

Terraform is a massive improvement over Ansible if you do anything non-trivial; even if it sucks, it sucks significantly less than Ansible at managing infrastructure resources. I sometimes fool myself into thinking I can use Ansible in simple cases and that Terraform would be overkill but so far I've regretted those decisions every time.

Ansible wasn't designed for IaC, but configuration management, and even at that wasn't the best tool.

What made it popular was that it was easiest to start with, but that's pretty much all of its strength compared to the competition.

Re: Terraform is currently not reviewing community pull requests

#98
post #81

Earlier quoted context omitted.

I don't understand why people think that just doing unsolicitied work and pressing a button means the people on the other side are obligated to spend time reviewing and integrating it. GitHub has weirdly unbalanced open source contributions with a heavier burden and burnout on maintainers. Contributing to a project doesn't mean just slinging code and calling it good. Communicate--talk to the people maintaining the co…

There is such a thing as open source project with "pull requests welcome" in readme and whole elaborate "how to contribute" wiki chapter. Except when you follow that wiki to the T, it still ends up ignored because no one is reading pull requests. It is not that these contributions are going out of nowhere, from clueless people who dont realized maintainers dont want pull requests. Pretty often maintenners wanted pull…

This, big time. It's a matter of setting expectations. If you don't want PRs, don't make it seem like you want PRs.

Re: Terraform is currently not reviewing community pull requests

#99
post #97

Earlier quoted context omitted.

Terraform is a massive improvement over Ansible if you do anything non-trivial; even if it sucks, it sucks significantly less than Ansible at managing infrastructure resources. I sometimes fool myself into thinking I can use Ansible in simple cases and that Terraform would be overkill but so far I've regretted those decisions every time.

Ansible wasn't designed for IaC, but configuration management, and even at that wasn't the best tool. What made it popular was that it was easiest to start with, but that's pretty much all of its strength compared to the competition.

Ansible is sort of bad at everything, and does a few things decently.

I use it as an orchestrator / clusterssh replacement, but for configuration management it makes me nervous because I can't trust it to just not break for stupid reasons.

Re: Terraform is currently not reviewing community pull requests

#100

So Terraform manages to become the recommended DevOps tool for most cloud providers and now they won't even accept PRs to improve and add features from the community? I think there are greater issues here, first that we centralized around so few major providers instead of improving tooling to scale to any hosting provider and 2 that we let hosting providers create so much abstraction that each one requires an entirel…

> So Terraform manages to become the recommended DevOps tool for most cloud providers It's not the recommended devops tool for any cloud provider. > and now they won't even accept PRs to improve and add features from the community? Random people writing code doesn't make that code valuable or of any sound quality. They have employees whose jobs it is to improve and add features to their software. > Clouds should be a…

> It's not the recommended devops tool for any cloud provider.

The Deployment manager templates under CFT for GCP specifically state they recommend the Terraform modules.

It is also the first provider listed under Oracle cloud. Pretty much every cloud list it as the preferred DevOps tool.

> Random people writing code doesn't make that code valuable or of any sound quality. They have employees whose jobs it is to improve and add features to their software.

It doesn't mean that it isn't. You act like only employees can write valuable code with sound quality, when in fact the opposite could be true and often is.

> Clouds are and should be exactly as simple or complex as their customers request. Clouds should not be built around opinionated forum posts.

The concept of a cloud provider is not anything unique. Hence why there are so many of them implementing their own API. Cloud providers budgets are heavily skewed to marketing, because if everyone could get the rates available through OVH, Hetzner, etc while still getting the same features through their own 3+node zero-config cluster then no one would pay the outrageous prices of AWS, Azure, etc.

Post reply on HN