Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Terraform is currently not reviewing community pull requests

github.com

Post reply on HN
Print view View original

81–90 of 120 posts

Re: Terraform is currently not reviewing community pull requests

#81

Post by watwut »

qbasic_forever wrote: post #26
leetrout wrote: post #6

Earlier quoted context omitted.

I had a conversation with my coworkers when I worked there about being upfront with folks that we wouldn't review or accept their PR and stop leaving people hanging (this was on the TFE provider). I'm glad this was added. I stand by my statement then and now: there is nothing worse than contributing to something open source and then have your PR completely ignored.

I don't understand why people think that just doing unsolicitied work and pressing a button means the people on the other side are obligated to spend time reviewing and integrating it. GitHub has weirdly unbalanced open source contributions with a heavier burden and burnout on maintainers. Contributing to a project doesn't mean just slinging code and calling it good. Communicate--talk to the people maintaining the co…

There is such a thing as open source project with "pull requests welcome" in readme and whole elaborate "how to contribute" wiki chapter. Except when you follow that wiki to the T, it still ends up ignored because no one is reading pull requests. It is not that these contributions are going out of nowhere, from clueless people who dont realized maintainers dont want pull requests. Pretty often maintenners wanted pull requests, made sure to promote the option and then found themselves unable/unwilling to merge them in.

I am not saying projects must merge in pull requests. I am saying they should not have "please contribute it is welcome" messages in their readmes.

And on second plan, there are those campaigns to make people contribute. And shaming of companies/people for freeloading if they dont contribute - especially here on HN. Again, if then people conclude that contribution is something expected, it is not only their own fault.

Re: Terraform is currently not reviewing community pull requests

#83

Post by PetahNZ »

jasonkester wrote: post #78
mwaitjmp wrote: post #15

Earlier quoted context omitted.

Out of interest then how do you proceed? Do you fork the code and run your own patched version?

Personally, I tend to post the change in a comment on the issue that it fixes. I don't generally bother with doing a formal PR, since that would mean setting up the repo in a dev environment, branching, etc. and would be a bunch of extra work. Locally, I just make the change and check it in to my project. Here's an example: https://github.com/xwpongithub/vue-range-slider/issues/3#iss...

You can literally edit the file in github and submit a PR with a few clicks.

Re: Terraform is currently not reviewing community pull requests

#84

Post by void_mint »

encryptluks2 wrote: post #33

So Terraform manages to become the recommended DevOps tool for most cloud providers and now they won't even accept PRs to improve and add features from the community? I think there are greater issues here, first that we centralized around so few major providers instead of improving tooling to scale to any hosting provider and 2 that we let hosting providers create so much abstraction that each one requires an entirel…

> So Terraform manages to become the recommended DevOps tool for most cloud providers

It's not the recommended devops tool for any cloud provider.

> and now they won't even accept PRs to improve and add features from the community?

Random people writing code doesn't make that code valuable or of any sound quality. They have employees whose jobs it is to improve and add features to their software.

> Clouds should be as

Clouds are and should be exactly as simple or complex as their customers request. Clouds should not be built around opinionated forum posts.

Re: Terraform is currently not reviewing community pull requests

#85

Post by dtech »

loeg wrote: post #69
geerlingguy wrote: post #50

Earlier quoted context omitted.

There are many projects where just doing that would be the equivalent of a full time position. Even saying no requires a skilled review.

If you are rejecting all PRs, that doesn't require skilled review -- a bot can do it.

Are you really open source in spirit at that point though?

Re: Terraform is currently not reviewing community pull requests

#86

Post by nitrogen »

dtech wrote: post #85
loeg wrote: post #69

Earlier quoted context omitted.

If you are rejecting all PRs, that doesn't require skilled review -- a bot can do it.

Are you really open source in spirit at that point though?

Yes. Both the cathedral and the bazaar are valid approaches to OSS project management, with pros and cons.

Re: Terraform is currently not reviewing community pull requests

#87

Post by kubanczyk »

mdaniel wrote: post #58

I recall once upon a time there was a GitHub project wherein the owner would just immediately merge any PRs that were opened -- I believe it was a social experiment, and I don't recall the exact nature of the repo in order to know if that kind of thing is ludicrous here. But I do think it'd be good fun to take this lull and find out the outcome of a hypothetical github.com/open-terraform/open-terraform which just ran…

Canonical article about that:

Pieter Hintjens "Why Optimistic Merging Works Better" (2015) http://hintjens.com/blog:106

Re: Terraform is currently not reviewing community pull requests

#88

Post by zxcvbn4038 »

devcpp wrote: post #53
jamesfinlayson wrote: post #52

Earlier quoted context omitted.

Looking at what CloudFormation can and can't do it seems like completely different teams work on a service and its CloudFormation support. I guess Amazon use the AWS API internally?

I work at AWS. The service teams do own and write their CloudFormation providers, although if you've written a custom provider you'd see it is somewhat clunky, so it's sometimes considered more of an operational burden, and you can tell. We dogfood both the SDK and CloudFormation internally, we just deal with its numerous gripes much the same way you would externally (although we can also contact service teams direct…

Million dollar question would be if all the “feature requests” that AWS support opens when they don’t know what else to do actually go someplace or if they just get swept aside every few days. I’ve always been under the impression they receive very little or no attention. Even bugs where I have included a reproducible test case that results in an internal error, they just keep trying to close the ticket every few days until you go on vacation or e-mail burps and you miss the notice.

Re: Terraform is currently not reviewing community pull requests

#89

Post by im2nguyen »

don-code wrote: post #24
jdavis703 wrote: post #17

Earlier quoted context omitted.

Yes, just use our own forked version.

I do this. I wish I didn't. First of all, building a provider isn't straightforward. The best way I've found to do this is to wrap `terraform init`, and have it `docker run` a build process for a plugin version that never existed - then dumping the built provider into the `.terraform` directory for the project. It's prone to failure; new users of the Terraform project complain that the build eats 8GB of RAM and takes…

You can sideload Terraform providers so you don't need to do this. I personally recommend the [implicit local mirror directory](https://www.terraform.io/docs/cli/config/config-file.html#im...) where you just place your provider in your OS's respective Terraform plugin directory (MacOS: `$HOME/.terraform.d/plugins/`).

There's other ways to sideload providers on that docs page too

Re: Terraform is currently not reviewing community pull requests

#90

Post by lloydatkinson »

dagss wrote: post #4
lloydatkinson wrote: post #3

Wow. Glad I started using ARM/Bicep for my recent learning about devops.

ARM is a complete joke, and Bicep compiles down to ARM. (More details: ARM is simply a dumb script that says "do this, do that", it doesn't interact with your cloud resources in any smart way. As one example: You can download a template for an Azure SQL instance from the Azure portal. That template will then randomly fail to execute, because it contains two "configuration" child resources of Azure SQL, which ARM will…

Sounds like you're just angry I don't like the same technologies as you. I don't need terraform because I only work with Azure. What are you going to do to stop me?
Post reply on HN