“Please don't waste maintainers' time on your KPI grabbing patches”

Post by d4v3 » Fri, Jun 25, 2021, 2:39 PM UTC

roenxi wrote: post #61

nevinera wrote: post #52

Earlier quoted context omitted.

It's not nefarious , it's a pattern of a particular company trying to game a metric, to boost their reputation. Pretend you were a dev, and your effectiveness was mostly described within your 500-engineer department in terms of "how many pull-requests" you merged each month. In the abstract, that seems like a reasonable metric to use - it does seem to correlate with actual output, and encourages smaller slicing (whic…

This looks boring. This is a scene that plays out in every company weekly. The stakes are trivial, there is no evidence of ill intent anywhere. Nobody has done anything particularly badly behaved. Nothing here is a shining example of good behaviour. There isn't a feel-good aspect. I suppose the question is, who are the 100+ people who upvoted this, and why?

Post by severino » Fri, Jun 25, 2021, 2:42 PM UTC

paganel wrote: post #56

> already broken reputation. What's that "broken reputation"? Apart from the media circus about 5G. Anything that Huawei has done wrong related to the Linux kernel or the open source community generally speaking?

Post by matheusmoreira » Fri, Jun 25, 2021, 2:45 PM UTC

jvanderbot wrote: post #75

The sense I got from the post was: "It's fine for noobs to cut their teeth on small issues, but as one of the largest tech companies, I'd expect more from your commits. It's obvious you're not even trying".

Post by MR4D » Fri, Jun 25, 2021, 2:49 PM UTC

41209 wrote: post #91

ridaj wrote: post #30

Earlier quoted context omitted.

It's not about security. It's about wasting reviewers' time. I too would be annoyed if someone was submitting, say, whitespace-only changes, or similar cleanup, non-functional changes - I still have to review them and my time would be better spent looking at actually meaningful changes that make the product better. It's OK if someone is just learning the ropes with an easy change, but this seems to be more like peopl…

I think there was some medium post by a guru where he claimed the best way to get experience was to submit as many spelling error pull request as possible. That way he can throw in his resume that he's contributed to a dozen or so open source projects. Given how broken the hiring process is, it wouldn't surprise me if this works

Post by tablespoon » Fri, Jun 25, 2021, 2:52 PM UTC

41209 wrote: post #91

ridaj wrote: post #30

Earlier quoted context omitted.

It's not about security. It's about wasting reviewers' time. I too would be annoyed if someone was submitting, say, whitespace-only changes, or similar cleanup, non-functional changes - I still have to review them and my time would be better spent looking at actually meaningful changes that make the product better. It's OK if someone is just learning the ropes with an easy change, but this seems to be more like peopl…

I think there was some medium post by a guru where he claimed the best way to get experience was to submit as many spelling error pull request as possible. That way he can throw in his resume that he's contributed to a dozen or so open source projects. Given how broken the hiring process is, it wouldn't surprise me if this works