“Please don't waste maintainers' time on your KPI grabbing patches”

Post by [deleted] » Fri, Jun 25, 2021, 2:10 PM UTC

ridaj wrote: post #30

tut-urut-utut wrote: post #9

I see that these "cleanup" patches are not bringing much value, bust I also don't see why fixing spelling mistakes or log messages is considered as harmful, KPI boosting or not. The maintainer even said if someone else sent those patches it would be OK, but not if Huawei employees do it. If they distrust Huawei so much, why not just ban them from committing, the same way they did recently with university "security re…

It's not about security. It's about wasting reviewers' time. I too would be annoyed if someone was submitting, say, whitespace-only changes, or similar cleanup, non-functional changes - I still have to review them and my time would be better spent looking at actually meaningful changes that make the product better. It's OK if someone is just learning the ropes with an easy change, but this seems to be more like peopl…

Post by [deleted] » Fri, Jun 25, 2021, 2:10 PM UTC

Post by newsclues » Fri, Jun 25, 2021, 2:11 PM UTC

lmilcin wrote: post #38

I have worked in team with some kernel developers at Samsung, years ago, so let me put some perspective for those who do not understand the dynamics. In some companies, the amount of patents or Linux kernel patches you get accepted is direct measure of your success. As you know, whatever you measure becomes a target -- these guys feel very pressed to get ANY kernel commits accepted, no matter how small, irrelevant or…

Post by nevinera » Fri, Jun 25, 2021, 2:11 PM UTC

roenxi wrote: post #61

nevinera wrote: post #52

Earlier quoted context omitted.

It's not nefarious , it's a pattern of a particular company trying to game a metric, to boost their reputation. Pretend you were a dev, and your effectiveness was mostly described within your 500-engineer department in terms of "how many pull-requests" you merged each month. In the abstract, that seems like a reasonable metric to use - it does seem to correlate with actual output, and encourages smaller slicing (whic…

This looks boring. This is a scene that plays out in every company weekly. The stakes are trivial, there is no evidence of ill intent anywhere. Nobody has done anything particularly badly behaved. Nothing here is a shining example of good behaviour. There isn't a feel-good aspect. I suppose the question is, who are the 100+ people who upvoted this, and why?

Post by arvigeus » Fri, Jun 25, 2021, 2:15 PM UTC

paganel wrote: post #56

> already broken reputation. What's that "broken reputation"? Apart from the media circus about 5G. Anything that Huawei has done wrong related to the Linux kernel or the open source community generally speaking?