Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

“Please don't waste maintainers' time on your KPI grabbing patches”

lkml.org

Post reply on HN
Print view View original

11–20 of 277 posts

Re: “Please don't waste maintainers' time on your KPI grabbing patches”

#12

Post by hashhar »

Without any context it looks like someone overreacted. It's essentially saying anybody else than Huawei sending cleanup patches is welcome but Huawei is not. Then they try to backtrack that statement by putting out a long list of things which aren't comparable in complexity to the original topic.

Without more context I bet this thread is going to go off-topic.

Re: “Please don't waste maintainers' time on your KPI grabbing patches”

#15

Post by exdsq »

tut-urut-utut wrote: post #9

I see that these "cleanup" patches are not bringing much value, bust I also don't see why fixing spelling mistakes or log messages is considered as harmful, KPI boosting or not. The maintainer even said if someone else sent those patches it would be OK, but not if Huawei employees do it. If they distrust Huawei so much, why not just ban them from committing, the same way they did recently with university "security re…

I guess if you have hundreds of trivial patches it'd take ages to review and merge them, and due to kpis Huawei are being deliberately inefficient

Re: “Please don't waste maintainers' time on your KPI grabbing patches”

#16

Post by MichaelRazum »

hashhar wrote: post #12

Without any context it looks like someone overreacted. It's essentially saying anybody else than Huawei sending cleanup patches is welcome but Huawei is not. Then they try to backtrack that statement by putting out a long list of things which aren't comparable in complexity to the original topic. Without more context I bet this thread is going to go off-topic.

Sounds like he is saying. Huawei is doing a lot of trivial cleanups to be able to say like they are a major contributor. Basically the argument is:

- trivial patches are ok, if you are just doing it for practice. Like a student.

- trivial patches are not ok, if you are doing a lot of them and only for the purpose to get a higher contribution ranking (like commits per company)

Re: “Please don't waste maintainers' time on your KPI grabbing patches”

#17

Post by ma2rten »

tut-urut-utut wrote: post #9

I see that these "cleanup" patches are not bringing much value, bust I also don't see why fixing spelling mistakes or log messages is considered as harmful, KPI boosting or not. The maintainer even said if someone else sent those patches it would be OK, but not if Huawei employees do it. If they distrust Huawei so much, why not just ban them from committing, the same way they did recently with university "security re…

These small patches create some overhead for maintainers. He actually said in the follow up message that grouping them together is fine.

Please at least merge all those small fixes into a larger patchset, and with a good cover letter to explain the reason (and auto-tool to do the change if possible) for all the involved maintainers, so that all of us are on the same page.

Re: “Please don't waste maintainers' time on your KPI grabbing patches”

#18

Post by buran77 »

hashhar wrote: post #12

Without any context it looks like someone overreacted. It's essentially saying anybody else than Huawei sending cleanup patches is welcome but Huawei is not. Then they try to backtrack that statement by putting out a long list of things which aren't comparable in complexity to the original topic. Without more context I bet this thread is going to go off-topic.

The remark close to the end, that this is just further damages Huawei's already damaged reputation, especially after beginning with "I did the same at some point", hints at a personal issue rather than professional objection.

There's no professional reason to take such an unrelated jab so it feels more like this individual just found an opportunity to settle a score, or has a different problem with Huawei that's harder to support publicly.

Re: “Please don't waste maintainers' time on your KPI grabbing patches”

#19

Post by quyleanh »

> "you're really just damaging the already broken reputation."

Actually, with this email and the viral on HN, I think this quotation is true for Qu Wenruo. He/she has just damaged the already broken reputation.

Not only Huawei, but also other companies will take a look at this accident to get the learned lessons.

Post reply on HN