Ad block shouldn't break your checkout

#1

Post by infomiho » Tue, May 18, 2021, 1:00 PM UTC

Ad block shouldn't break your checkout
ilakovac.com

Re: Ad block shouldn't break your checkout

#2

Post by moviuro » Tue, May 18, 2021, 1:03 PM UTC

LOL, article is hidden when uBlock is active. Way to go!

Re: Ad block shouldn't break your checkout

#3

Post by infomiho » Tue, May 18, 2021, 1:08 PM UTC

moviuro wrote: post #2

LOL, article is hidden when uBlock is active. Way to go!

Hey, not sure what you mean :) I use uBlock Origin in Chrome and the article renders okay for me?

The site doesn't really use any JS other then some privacy friendly analytics.

Re: Ad block shouldn't break your checkout

#4

Post by pndy » Tue, May 18, 2021, 1:18 PM UTC

moviuro wrote: post #2

LOL, article is hidden when uBlock is active. Way to go!

Displays fine for me - gotta be your filter lists subscriptions

Re: Ad block shouldn't break your checkout

#5

Post by moviuro » Tue, May 18, 2021, 1:21 PM UTC

infomiho wrote: post #3

moviuro wrote: post #2

LOL, article is hidden when uBlock is active. Way to go!

Hey, not sure what you mean :) I use uBlock Origin in Chrome and the article renders okay for me? The site doesn't really use any JS other then some privacy friendly analytics.

Ah well, I blocked all JS for your domain, that worked.

The article was collapsing when I had uBlock on FFx, I only saw your bottom (C)opyright.

Re: Ad block shouldn't break your checkout

#6

Post by al2o3cr » Tue, May 18, 2021, 1:25 PM UTC

TBH I don't see this as a TeeSpring problem - the code on their page guards against a realistic scenario (the GA script fails to load), but the "break" is caused by uBlock's changes.

The article's title is correct: ad block shouldn't break checkout. Injecting a bogus value into a global breaks checkout, so ad block shouldn't do that.

Re: Ad block shouldn't break your checkout

#7

Post by LinuxBender » Tue, May 18, 2021, 1:31 PM UTC

Is the issue that the store built a checkout dependency on google analytics to force people to disable uBlock or attempt to force uBlock to allow google analytics for this domain?

Re: Ad block shouldn't break your checkout

#8

Post by infomiho » Tue, May 18, 2021, 2:39 PM UTC

LinuxBender wrote: post #7

Is the issue that the store built a checkout dependency on google analytics to force people to disable uBlock or attempt to force uBlock to allow google analytics for this domain?

I believe that it was an unintentional mistake on TeeSpring's end.

Searching for the dummy function uBlock Origin uses for window.ga https://github.com/gorhill/uBlock/blob/master/src/web_access...

This reveals that this has been in uBlock Origin since 2019.

Re: Ad block shouldn't break your checkout

#9

Post by tyingq » Tue, May 18, 2021, 2:42 PM UTC

al2o3cr wrote: post #6

TBH I don't see this as a TeeSpring problem - the code on their page guards against a realistic scenario (the GA script fails to load), but the "break" is caused by uBlock's changes. The article's title is correct: ad block shouldn't break checkout. Injecting a bogus value into a global breaks checkout, so ad block shouldn't do that.

I agree with that, though if I'm TeeSpring, I'd fix it anyway. It's silly to throw out incoming business. I assume the same thing would happen if there were a brief GA outage.

Re: Ad block shouldn't break your checkout

#10

Post by sparker72678 » Tue, May 18, 2021, 2:47 PM UTC

I’ve been running into this sort of thing more and more and more. It’s crazy how many page rely on some kind of google tag manager event before they’ll load the real content or perform the main function of the page.

Don’t all developers have ad blockers (clearly not)? I understand managers not testing for this, but for my own work it’d never load for me as a Dev, even.