Live data from Hacker News

A warning about 5.12-rc1

lwn.net

91–100 of 115 posts

Re: A warning about 5.12-rc1

#91
This is one of the best examples of leadership I’ve ever seen...

Huge impactful problem....

Gets past the gatekeepers...

Things go bad...

Issue gets discovered & corrected....

Leader writes an honest and open note to explain the situation and actually apologizes.

Corporate America could learn something from this.

Re: A warning about 5.12-rc1

#92
post #89

I used to assume that Linux had a huge test suite with hundreds of thousands of tests, given the crazy feature matrix that the kernel has to support. And that they would have started requiring tests for new features and bug fixes. Alas, that's not the case. There are a few external test suites like the Linux Test Project [1], but nothing that looks very extensive. The process seems to mostly rely on maintainers givin…

Comment rom "Helping Out with LTS Kernel Releases"[0]: "I find it amusing that the answer to "how can I help test" is "that people test the -rc releases when I announce them, and let me know if they work or not for their systems/workloads/tests/whatever". No smoke tests, no automated tools, no suggested workloads, no fuzzing, just "fool around and report back". There probably are lots of kernel testing tools around,…

I suspect lots of downstreams kernel developers do run smoke tests, automated tools, workloads and fuzzing.

It's just done individually, with each person hitting their own niche, and without a single all-powerful CI pipeline that's visible.

Re: A warning about 5.12-rc1

#93
post #87

I'd find it interesting to read an analysis how this bug could have happened from a technical point. Like... is swap file support going shortcuts in the kernel so that it can corrupt the file system the swap file is residing on? Because (at least in my hope) no matter of write() or whatever calls on a file handle should cause a filesystem corruption...

The swap file code does not go through the filesystem. It's the exact same code which is used for a swap partition or a swap file, and it writes directly to the block device (the partition). The main difference is that, if you have a swap file, the "swapon" call asks the filesystem to tell it which ranges in the block device contain the swap, instead of using the whole block device.

I did not know this - it makes sense, but it certainly a surprise.

Re: A warning about 5.12-rc1

#94
post #51

Earlier quoted context omitted.

> So I'm not blaming the developers in question, Much kinder than past Linus writings. I loved it too. "Double ungood" works at least as good as the swearing.

I can recall a colleague, many years ago, sometimes using "doubleplusungood", often shortened -- in (typical lazy UNIX admin style -- to just ++ungood Later, another cow-orker tried using a slight variant ... ++!good ... although that one never really caught on -- apparently it didn't compile or something (maybe because we were using Red Hat's version "2.96" of gcc at the time?). -- (+10 Internet points if you get th…

++ can't operate on !good because it's not an lvalue (i.e. not assignable).

    typedef double winston;
    winston smith(int good) { return (double)+!good; }

Re: A warning about 5.12-rc1

#95
post #66

Earlier quoted context omitted.

The answer to why a partition is constant size: you are permanently reserving that amount of disk space, that's what a partition is. Swapfiles aren't dynamic for the same reason, but, you can have multiple swapfiles, and when they are empty, you can discard them. If you really want dynamic swap, you can run swapfiled, which will monitor memory usage and create and mount swapfiles of a given granularity on demand. If…

> If you have a matlab script that needs 1TB of swap, I don't know why you're running it here. Buy a server with a TB of RAM, or rent one. why would you assume that having a machine with 1TB of free space means that you have any way of spending money ?

I do not believe the parent comment were assuming they have money just suggesting that the grandparent comment not do what they were currently doing.

A 1 TB swap sounds like it will thrash a disk to the point of failure pretty quickly and perform quite poorly compared to a system with more appropriate amounts of RAM.

Having to replace disks more frequently and have tasks take longer than an appropriately equipped system could potentially be the more expensive in the long run.

Re: A warning about 5.12-rc1

#96

I used to assume that Linux had a huge test suite with hundreds of thousands of tests, given the crazy feature matrix that the kernel has to support. And that they would have started requiring tests for new features and bug fixes. Alas, that's not the case. There are a few external test suites like the Linux Test Project [1], but nothing that looks very extensive. The process seems to mostly rely on maintainers givin…

To be honest, many codebases that I've worked on with large automated test suites seemed to have approximately the same relative occurrence of bugs as codebases with zero automated tests.

Re: A warning about 5.12-rc1

#97
post #89

I used to assume that Linux had a huge test suite with hundreds of thousands of tests, given the crazy feature matrix that the kernel has to support. And that they would have started requiring tests for new features and bug fixes. Alas, that's not the case. There are a few external test suites like the Linux Test Project [1], but nothing that looks very extensive. The process seems to mostly rely on maintainers givin…

Comment rom "Helping Out with LTS Kernel Releases"[0]: "I find it amusing that the answer to "how can I help test" is "that people test the -rc releases when I announce them, and let me know if they work or not for their systems/workloads/tests/whatever". No smoke tests, no automated tools, no suggested workloads, no fuzzing, just "fool around and report back". There probably are lots of kernel testing tools around,…

Several people booting their favourite distro with the new kernel stresses a lot of areas at once.

Yes, it's a manual test, but it "does the job" (or 99% of it at least)

Re: A warning about 5.12-rc1

#98

Why are swap files/partitions constant size? Most of the time, I don't need any swap at all, and any swap file/partition is wasted space. While hibernated, I need ~the amount of system ram as swap. While running some horrendous matlab script, I need about 1TB of swap. Yet linux won't dynamically allocate it like other files. I'm forced to constantly resize it manually to save space or be able to do more things.

You've received a bunch of replies about why it needs to be statically allocated, but it's worth noting that several OSes have dynamically allocated swap files that are managed by the OS: macOS, Windows, and OS/2 come to mind.

Windows uses a single file by default (C:\pagefile.sys), while macOS allocates them in chunks (/private/var/vm/swapfile).

Re: A warning about 5.12-rc1

#99
post #96

I used to assume that Linux had a huge test suite with hundreds of thousands of tests, given the crazy feature matrix that the kernel has to support. And that they would have started requiring tests for new features and bug fixes. Alas, that's not the case. There are a few external test suites like the Linux Test Project [1], but nothing that looks very extensive. The process seems to mostly rely on maintainers givin…

To be honest, many codebases that I've worked on with large automated test suites seemed to have approximately the same relative occurrence of bugs as codebases with zero automated tests.

Automated testing is good at catching (especially immediate) regressions, but also it is a development tool and a communication tool.

Re: A warning about 5.12-rc1

#100
> Additionally, he is asking maintainers to not start branches from 5.12-rc1 to avoid future situations where people land in the buggy code while bisecting problems.

Nice. Everywhere I've worked, once the fix has been committed the job is done. I should be more conscientious about preventing bad commits from being in branch histories like this.

Post reply on HN